Add emptyDir volume support to kube play #15473
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Any idea why govet is complaining when I haven't touched the code there https://github.com/containers/podman/pull/15473/checks?check_run_id=8021235120 |
|
Maybe the version of the linter we use updated? Not sure |
|
@cevich any idea what I am doing wrong here. I have rebased with upstream main so don't think I should be missing any linter updates |
Unfortunately no, I'm not sure :( According to https://cirrus-ci.com/github/containers/podman/main problem isn't a problem that's crept into `main'. So it must be something specific to changes in this PR. |
|
See if adding this patch fixes it. |
umohnani8
force-pushed
the
empty-dir
branch
4 times, most recently
from
0837769 to
6c34c09
Compare
When a kube yaml has a volume set as empty dir, podman will create an anonymous volume with the empty dir name and attach it to the containers running in the pod. When the pod is removed, the empy dir volume created is also removed. Add tests and docs for this as well. Signed-off-by: Urvashi Mohnani <[email protected]>
|
Should an emptyDir be destroyed when you podman kube down? |
|
That should be automatically handled by the anonymous volumes - they autoremove when the last container using them is removed |
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
When a kube yaml has a volume set as empty dir, podman
will create an anonymous volume with the empty dir name and
attach it to the containers running in the pod. When the pod
is removed, the empy dir volume created is also removed.
Add tests and docs for this as well.
Fixes #13309
Signed-off-by: Urvashi Mohnani [email protected]
Does this PR introduce a user-facing change?