Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document restrictions on transport in FROM #15429

Merged

Conversation

graywolf-at-work
Copy link
Contributor

@graywolf-at-work graywolf-at-work commented Aug 23, 2022

When using remote podman client, not all transports work as expected. So
document this limitation.

Fixes: #15141

Does this PR introduce a user-facing change?

Improve documentation for --from in context of remote podman client

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 23, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 23, 2022
When using remote podman client, not all transports work as expected. So
document this limitation.

Fixes: containers#15141
Signed-off-by: Tomas Volf <[email protected]>
@mheon
Copy link
Member

mheon commented Aug 23, 2022

@flouthoc @nalind Will this be needed in Buildah as well?

@mheon
Copy link
Member

mheon commented Aug 23, 2022

Wait, nevermind, need more coffee. Buildah doesn't have a remote API. Sorry for the noise.

@mheon
Copy link
Member

mheon commented Aug 23, 2022

/approve

@vrothberg PTAL, I think some of these transports were restricted entirely, no?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: graywolf-at-work, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@rhatdan
Copy link
Member

rhatdan commented Aug 23, 2022

/lgtm
Thanks @graywolf-at-work

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit 2651009 into containers:main Aug 23, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remote build: document that only the docker and containers-storage transport work
4 participants