Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect, image: alias .Config.HealthCheck to .HealthCheck for compatibility #15424

Merged

Conversation

flouthoc
Copy link
Collaborator

Support inspecting image healthcheck using docker supported
.Config.HealthCheck by aliasing field to .HealthCheck

Now supports

podman image inspect -f "{{.Config.Healthcheck}}" imagename

Closes: #14661

inspect,image: now supports filter "{{.Config.Healthcheck}}"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@flouthoc
Copy link
Collaborator Author

@vrothberg @containers/podman-maintainers PTAL

…bility

Support inspecting image healthcheck using docker supported
`.Config.HealthCheck` by aliasing field to `.HealthCheck`

Now supports

```Console
podman image inspect -f "{{.Config.Healthcheck}}" imagename
```

Closes: containers#14661

Signed-off-by: Aditya R <[email protected]>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests aren't happy

[+0008s] time="2022-08-23T02:59:01-05:00" level=error msg="Printing inspect output: template: all inspect:1:25: executing "all inspect" at <.HealthCheck.Test>: can't evaluate field HealthCheck in type interface {}"

@flouthoc flouthoc force-pushed the inspect-image-healthcheck branch from 87962d4 to 70e103c Compare August 23, 2022 08:09
@flouthoc
Copy link
Collaborator Author

I did it for all type as well it was only needed for image type lets see if CI passes now.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mheon
Copy link
Member

mheon commented Aug 23, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit 833501a into containers:main Aug 23, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Healthcheck property of a container image cannot be printed via go template with podman inspect
4 participants