-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inspect, image: alias .Config.HealthCheck
to .HealthCheck
for compatibility
#15424
inspect, image: alias .Config.HealthCheck
to .HealthCheck
for compatibility
#15424
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vrothberg @containers/podman-maintainers PTAL |
…bility Support inspecting image healthcheck using docker supported `.Config.HealthCheck` by aliasing field to `.HealthCheck` Now supports ```Console podman image inspect -f "{{.Config.Healthcheck}}" imagename ``` Closes: containers#14661 Signed-off-by: Aditya R <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests aren't happy
[+0008s] time="2022-08-23T02:59:01-05:00" level=error msg="Printing inspect output: template: all inspect:1:25: executing "all inspect" at <.HealthCheck.Test>: can't evaluate field HealthCheck in type interface {}"
87962d4
to
70e103c
Compare
I did it for all type as well it was only needed for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
Support inspecting image healthcheck using docker supported
.Config.HealthCheck
by aliasing field to.HealthCheck
Now supports
podman image inspect -f "{{.Config.Healthcheck}}" imagename
Closes: #14661