FreeBSD build fixes for pkg/util and pkg/machine #15290
Conversation
|
LGTM |
|
Rebased which should fix the OSX Cross build (related to markdown-preprocess) |
|
CI is yelling about unit tests - can you add |
|
Code changes LGTM |
For some reason GNU make doesn't define this on FreeBSD. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <[email protected]>
Remove freebsd from the unsupported list and add missing symbols. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <[email protected]>
Add missing symbols for freebsd and freebsd/amd64. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <[email protected]>
Done. There are a few more PRs to go before podman even builds on FreeBSD and quite a few more before basic functionality works so unit tests are a little premature. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfr, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
This makes the pkg/util and pkg/machine modules build on FreeBSD. It also fixes 'make clean' on FreeBSD - docs/Makefile assumes that $RM is set to something which behaves like /bin/rm and this wasn't set for me for some reason.
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?