-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remote e2e: speed up populating and loading cache #15266
Conversation
The remote e2e tests run significantly slower than the local ones. In some runs I have seen a factor of two. Among other things, I suspect the continuous loading of the cache to be a bottleneck as (un)taring is CPU-intensive. Speed up the aforementioned bottleneck by using the local podman binary to populate and load the cache to workaround these more expensive remote operations. Signed-off-by: Valentin Rothberg <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Now, I am curious how much we'd gain. |
Nothing ... |
@baude, did I misread the code and the e2e tests already use the local podman for that? |
cirrus-pr-timing:
EDIT: I obviously have a bug in my script. Nothing runs in one minute. |
@edsantiago I think your scripts are accurate. Cirrus states 1min https://github.com/containers/podman/pull/15266/checks?check_run_id=7765843970 |
Oh - duh, it's because of the test-skipper. Whew. Yeah, results are good. Only |
Indeed the remote tests already use the local one: https://github.com/containers/podman/blob/main/test/e2e/libpod_suite_remote_test.go#L154 |
@vrothberg yes, they do. i verified yesterday. i dug quite a bit into this though and some really odd findings. |
The remote e2e tests run significantly slower than the local ones.
In some runs I have seen a factor of two. Among other things, I
suspect the continuous loading of the cache to be a bottleneck as
(un)taring is CPU-intensive.
Speed up the aforementioned bottleneck by using the local podman binary
to populate and load the cache to workaround these more expensive remote
operations.
Signed-off-by: Valentin Rothberg [email protected]
Does this PR introduce a user-facing change?