Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote e2e: speed up populating and loading cache #15266

Closed
wants to merge 1 commit into from

Conversation

vrothberg
Copy link
Member

The remote e2e tests run significantly slower than the local ones.
In some runs I have seen a factor of two. Among other things, I
suspect the continuous loading of the cache to be a bottleneck as
(un)taring is CPU-intensive.

Speed up the aforementioned bottleneck by using the local podman binary
to populate and load the cache to workaround these more expensive remote
operations.

Signed-off-by: Valentin Rothberg [email protected]

Does this PR introduce a user-facing change?

None

The remote e2e tests run significantly slower than the local ones.
In some runs I have seen a factor of two.  Among other things, I
suspect the continuous loading of the cache to be a bottleneck as
(un)taring is CPU-intensive.

Speed up the aforementioned bottleneck by using the local podman binary
to populate and load the cache to workaround these more expensive remote
operations.

Signed-off-by: Valentin Rothberg <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2022
@vrothberg
Copy link
Member Author

Now, I am curious how much we'd gain.

@vrothberg
Copy link
Member Author

Now, I am curious how much we'd gain.

Nothing ...

@vrothberg
Copy link
Member Author

@baude, did I misread the code and the e2e tests already use the local podman for that?

@edsantiago
Copy link
Member

edsantiago commented Aug 10, 2022

cirrus-pr-timing:

type distro user local remote container
int fedora-36 root 30:01 48:17 29:23
int ubuntu-2204 root 30:27 52:12
int fedora-36 rootless 32:28
int ubuntu-2204 rootless 30:51
sys fedora-36 root 01:08 01:13
sys fedora-36-aarch64 root 01:26 01:19
sys ubuntu-2204 root 01:16 01:15
sys fedora-36 rootless 01:17 01:25
sys ubuntu-2204 rootless 01:18
bud fedora-36 root 01:16 01:07

EDIT: I obviously have a bug in my script. Nothing runs in one minute.

@vrothberg
Copy link
Member Author

@edsantiago I think your scripts are accurate. Cirrus states 1min https://github.com/containers/podman/pull/15266/checks?check_run_id=7765843970

@edsantiago
Copy link
Member

Oh - duh, it's because of the test-skipper. Whew. Yeah, results are good. Only int tests ran, nothing else.

@vrothberg
Copy link
Member Author

@baude, did I misread the code and the e2e tests already use the local podman for that?

Indeed the remote tests already use the local one: https://github.com/containers/podman/blob/main/test/e2e/libpod_suite_remote_test.go#L154

@vrothberg vrothberg closed this Aug 10, 2022
@vrothberg vrothberg deleted the ci-speed-up branch August 10, 2022 15:42
@baude
Copy link
Member

baude commented Aug 11, 2022

@vrothberg yes, they do. i verified yesterday. i dug quite a bit into this though and some really odd findings.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants