Cirrus: Improve CI VM image updates for EC2 #15215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/release-note-label-needed
cevich
force-pushed
the
use_image_search
branch
from
9d6b1b9 to
d824b86
Compare
|
force-push: Rebased on main. Removed the image-update, so this commit only does the ID-search in EC2. |
|
Oh woops! This is going to break |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
cevich
changed the title
AWS EC2 keys VM images by an utterly unreadable, horrible to use, generated "AMI ID" value. This is very error prone for humans in practice, since it's impossible to tell one image from the next by eye. Worse, EC2 permits duplicate name-tag values, complicating image specification further. However fortunately, Cirrus-CI recently implemented a feature by which AMI's may be referenced by a name-tag search - choosing the most recent AMI found. Since the `containers/automation_images` build workflow always assigns a unique name + `$IMAGE_SUFFIX` value, we can simply re-use it for both AWS and GCP image specification. In other words as of this commit, specifying new CI VM images can be done by simply updating the `$IMAGE_SUFFIX` value as we've always done. No need to call out a specific AMI ID just for EC2 tasks. Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
use_image_search
branch
from
d824b86 to
d2d7898
Compare
cevich
changed the title
|
Force-push: Rebased on main. I fixed |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Does that mean this is ready for review? LGTM at first glance. |
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS EC2 keys VM images by an utterly unreadable and horrible to use "AMI
ID" value. This is very error prone for humans to use, since it's
impossible to tell one image from the next by eye. Worse, they permit
duplicate name-tag values (or any other tag), complicating image
selection further.
However, Cirrus-CI recently implemented a feature by which AMI's may be
referenced by name-tag search, where the most recent AMI is chosen.
Since the
containers/automation_imagesbuild workflow always assignsa unique
$IMAGE_SUFFIXvalue (based on the $CIRRUS_BUILD_ID), we cannow simply re-use it for both AWS and GCP image specification. In other
words to update VM images, simply update the
$IMAGE_SUFFIXvalueand you're done.
Signed-off-by: Chris Evich [email protected]
Does this PR introduce a user-facing change?