Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Refactor common options in man pages" #15186

Closed
wants to merge 1 commit into from

Conversation

vrothberg
Copy link
Member

This reverts commit 56039cf as it does
not pass the OSX Cross job in CI [1].

[1] https://github.com/containers/podman/pull/15175/checks?check_run_id=7666443981

Signed-off-by: Valentin Rothberg [email protected]

Does this PR introduce a user-facing change?

None

This reverts commit 56039cf as it does
not pass the OSX Cross job in CI [1].

[1] https://github.com/containers/podman/pull/15175/checks?check_run_id=7666443981

Signed-off-by: Valentin Rothberg <[email protected]>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 4, 2022
@gbraad
Copy link
Member

gbraad commented Aug 4, 2022

/approve

Copy link
Member

@gbraad gbraad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2022

@gbraad: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gbraad, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2022
@vrothberg
Copy link
Member Author

If https://github.com/containers/podman/pull/15188/files works, we can close this PR here.

@Luap99
Copy link
Member

Luap99 commented Aug 4, 2022

lets wait if #15188 works before merging

@vrothberg
Copy link
Member Author

#15188 works, so I am closing this PR here.

@vrothberg vrothberg closed this Aug 4, 2022
@vrothberg vrothberg deleted the fix-ci branch August 4, 2022 08:39
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants