-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Refactor common options in man pages" #15186
Conversation
This reverts commit 56039cf as it does not pass the OSX Cross job in CI [1]. [1] https://github.com/containers/podman/pull/15175/checks?check_run_id=7666443981 Signed-off-by: Valentin Rothberg <[email protected]>
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@gbraad: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gbraad, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
If https://github.com/containers/podman/pull/15188/files works, we can close this PR here. |
lets wait if #15188 works before merging |
#15188 works, so I am closing this PR here. |
This reverts commit 56039cf as it does
not pass the OSX Cross job in CI [1].
[1] https://github.com/containers/podman/pull/15175/checks?check_run_id=7666443981
Signed-off-by: Valentin Rothberg [email protected]
Does this PR introduce a user-facing change?