Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Cirrus: Support EC2 instances in hack/get_ci_vm.sh #15145

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

cevich
Copy link
Member

@cevich cevich commented Aug 1, 2022

Depends on:
containers/automation_images#160

Signed-off-by: Chris Evich [email protected]

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none labels Aug 1, 2022
@cevich cevich changed the title [CI:DOCS] Cirrus: Support EC2 instances in hack/get_ci_vm.sh [CI:DOCS] [WIP] Cirrus: Support EC2 instances in hack/get_ci_vm.sh Aug 2, 2022
@cevich cevich force-pushed the ec2_get_ci_vm branch 2 times, most recently from 782ef8a to 180c0b9 Compare August 2, 2022 20:28
@cevich cevich marked this pull request as ready for review August 2, 2022 20:28
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2022
@cevich
Copy link
Member Author

cevich commented Aug 2, 2022

HOW TO TEST:

  1. Checkout the PR from c/automation_images.
  2. In that repo, run make get_ci_vm IMG_SFX=latest (you'll need podman installed locally)
  3. Tag the resulting image quay.io/libpod/get_ci_vm:latest
  4. Checkout this PR, run hack/get_ci_vm.sh Build for fedora-36-aarch64 (you'll need an AWS access key and secret).

@cevich
Copy link
Member Author

cevich commented Aug 2, 2022

@lsm5 @edsantiago @baude PTAL when you have a moment. The changes here are pretty simple, the stuff over in containers/automation_images#160 is VERY scary-complex. I commented it as best as I could but at this point I'm really mostly interested in "does it work for you"

@edsantiago I don't think you have any AWS creds yet, myself or @lsm5 or @baude can get you some, just ping one of us.

@cdoern
Copy link
Contributor

cdoern commented Aug 3, 2022

@cevich going to look into this now. I am going to try and see if I can find any glaring issues in c/common before I have you make an AWS account for me

@cevich
Copy link
Member Author

cevich commented Aug 3, 2022

Thanks Charlie. Pushing a quick fix now for that mkdir problem you found...

@cevich cevich changed the title [CI:DOCS] [WIP] Cirrus: Support EC2 instances in hack/get_ci_vm.sh [CI:DOCS] Cirrus: Support EC2 instances in hack/get_ci_vm.sh Aug 3, 2022
@rhatdan
Copy link
Member

rhatdan commented Aug 4, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2022
@openshift-ci openshift-ci bot merged commit ccbb8e7 into containers:main Aug 4, 2022
@cevich cevich deleted the ec2_get_ci_vm branch April 18, 2023 14:46
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants