-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] Cirrus: Support EC2 instances in hack/get_ci_vm.sh #15145
Conversation
782ef8a
to
180c0b9
Compare
HOW TO TEST:
|
@lsm5 @edsantiago @baude PTAL when you have a moment. The changes here are pretty simple, the stuff over in containers/automation_images#160 is VERY scary-complex. I commented it as best as I could but at this point I'm really mostly interested in "does it work for you" @edsantiago I don't think you have any AWS creds yet, myself or @lsm5 or @baude can get you some, just ping one of us. |
@cevich going to look into this now. I am going to try and see if I can find any glaring issues in c/common before I have you make an AWS account for me |
Thanks Charlie. Pushing a quick fix now for that |
***Depends on:*** containers/automation_images#160 Signed-off-by: Chris Evich <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Depends on:
containers/automation_images#160
Signed-off-by: Chris Evich [email protected]
Does this PR introduce a user-facing change?