Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix container create/run throttle devices #15035

Merged
merged 1 commit into from
Jul 22, 2022
Merged

fix container create/run throttle devices #15035

merged 1 commit into from
Jul 22, 2022

Conversation

cdoern
Copy link
Contributor

@cdoern cdoern commented Jul 22, 2022

pod resource limits introduced a regression where FinishThrottleDevices was not called for create/run

Signed-off-by: Charlie Doern [email protected]

Does this PR introduce a user-facing change?

None

@cdoern
Copy link
Contributor Author

cdoern commented Jul 22, 2022

@edsantiago PTAL

@cdoern cdoern force-pushed the cgroup branch 2 times, most recently from 48439af to 1d122c0 Compare July 22, 2022 02:45
@giuseppe
Copy link
Member

LGTM but could we add a test to avoid the same regression in future?

@cdoern
Copy link
Contributor Author

cdoern commented Jul 22, 2022 •
edited
Loading

@giuseppe there are tests for create and run that were failing in @edsantiago 's CI PR. I am confused how they passed in the resource limit PR.

Maybe I'll add a system tests to be safe

@rhatdan
Copy link
Member

rhatdan commented Jul 22, 2022

LGTM
/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2022
@cdoern
Copy link
Contributor Author

cdoern commented Jul 22, 2022

ok @giuseppe @containers/podman-maintainers PTAL, this is relatively urgent to fix these flags for container create/run

giuseppe
giuseppe approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2022
@Luap99
Copy link
Member

Luap99 commented Jul 22, 2022

/hold tests are red

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2022
@cdoern
fix container create/run throttle devices
ad8940c 
pod resource limits introduced a regression where `FinishThrottleDevices` was not called for create/run

Signed-off-by: Charlie Doern <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2022
@cdoern
Copy link
Contributor Author

cdoern commented Jul 22, 2022

seems like the tests have a new line in their files >:| lets see if this fixes it

@cdoern
Copy link
Contributor Author

cdoern commented Jul 22, 2022

@Luap99 @rhatdan @giuseppe PTAL, all green now

giuseppe
giuseppe approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoern, giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cdoern
Copy link
Contributor Author

cdoern commented Jul 22, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2022
@openshift-merge-robot openshift-merge-robot merged commit da1f479 into containers:main Jul 22, 2022
@cdoern cdoern mentioned this pull request Jul 25, 2022
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees

@giuseppe giuseppe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cdoern @giuseppe @rhatdan @Luap99 @openshift-merge-robot