-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prune filter handling #14997
prune filter handling #14997
Conversation
this vendors in c/common thats why it is so large. a few PRs do this ATM so one will get in first! |
37d7d94
to
8952e02
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit. Nice work, @cdoern !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than one comment above.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, flouthoc, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
network and container prune could not handle the label!=... filter. vendor in c/common to fix this and add some podman level handling to make everything run smoothly resolves containers#14182 Signed-off-by: Charlie Doern <[email protected]>
/lgtm |
can we cancel the hold on this? or does anyone have objections @containers/podman-maintainers |
LGTM /hold cancel |
network and container prune could not handle the label!=... filter. vendor in c/common to fix this and
add some podman level handling to make everything run smoothly
resolves #14182
Signed-off-by: Charlie Doern [email protected]
Does this PR introduce a user-facing change?