Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prune filter handling #14997

Merged
merged 1 commit into from
Jul 27, 2022
Merged

prune filter handling #14997

merged 1 commit into from
Jul 27, 2022

Conversation

cdoern
Copy link
Contributor

@cdoern cdoern commented Jul 20, 2022

network and container prune could not handle the label!=... filter. vendor in c/common to fix this and
add some podman level handling to make everything run smoothly

resolves #14182

Signed-off-by: Charlie Doern [email protected]

Does this PR introduce a user-facing change?

--label=filter!=key now works as expected

@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Jul 20, 2022
@cdoern
Copy link
Contributor Author

cdoern commented Jul 20, 2022

this vendors in c/common thats why it is so large. a few PRs do this ATM so one will get in first!

@cdoern cdoern force-pushed the prune branch 3 times, most recently from 37d7d94 to 8952e02 Compare July 22, 2022 16:23
@rhatdan
Copy link
Member

rhatdan commented Jul 24, 2022

LGTM
/approve
@containers/podman-maintainers PTAL

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2022
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit. Nice work, @cdoern !

test/e2e/prune_test.go Show resolved Hide resolved
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one comment above.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoern, flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

network and container prune could not handle the label!=... filter. vendor in c/common to fix this and
add some podman level handling to make everything run smoothly

resolves containers#14182

Signed-off-by: Charlie Doern <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Jul 25, 2022

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@cdoern
Copy link
Contributor Author

cdoern commented Jul 27, 2022

can we cancel the hold on this? or does anyone have objections @containers/podman-maintainers

@Luap99
Copy link
Member

Luap99 commented Jul 27, 2022

LGTM

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2022
@openshift-merge-robot openshift-merge-robot merged commit eea8e57 into containers:main Jul 27, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman system prune --filter="label!=key" doesn't work
6 participants