Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus: comment out f35 for podman4 #14963

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Jul 18, 2022

We are not shipping podman4 on f35, so it's not worth CI time at
this point.

Signed-off-by: Lokesh Mandvekar [email protected]

@cevich PTAL
/cc @containers/podman-maintainers

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 18, 2022
@lsm5 lsm5 marked this pull request as ready for review July 18, 2022 18:09
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2022
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment out the YAML sections instead of removing them. For the sake of putting it all back in the future when F37 cycles begin.

@lsm5 lsm5 force-pushed the main-remove-f35-cirrus branch from f0a5130 to a5ee115 Compare July 18, 2022 18:44
@lsm5 lsm5 changed the title Cirrus: remove f35 for podman4 Cirrus: comment out f35 for podman4 Jul 18, 2022
@lsm5 lsm5 force-pushed the main-remove-f35-cirrus branch 2 times, most recently from 227a433 to 98e2d03 Compare July 18, 2022 18:58
@rhatdan
Copy link
Member

rhatdan commented Jul 18, 2022

LGTM
@cevich PTAL

@lsm5 lsm5 force-pushed the main-remove-f35-cirrus branch from 98e2d03 to 8d8d35f Compare July 18, 2022 19:03
.cirrus.yml Outdated Show resolved Hide resolved
We are not shipping podman4 on f35, so it's not worth CI time at
this point.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the main-remove-f35-cirrus branch from 8d8d35f to aa1711e Compare July 18, 2022 19:12
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 21cf30f into containers:main Jul 19, 2022
@lsm5 lsm5 deleted the main-remove-f35-cirrus branch March 16, 2023 11:25
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants