[wip] Podman push --all-tags option

cmd/podman/images/push.go

@@ -73,8 +73,8 @@ func init() {
 func pushFlags(cmd *cobra.Command) {
 	flags := cmd.Flags()
 
-	// For now default All flag to true, for pushing of manifest lists
-	pushOptions.All = true
+	flags.BoolVarP(&pushOptions.All, "all-tags", "a", false, "Push all tagged images in the repository")
+
 	authfileFlagName := "authfile"
 	flags.StringVar(&pushOptions.Authfile, authfileFlagName, auth.GetDefaultAuthFile(), "Path of the authentication file. Use REGISTRY_AUTH_FILE environment variable to override")
 	_ = cmd.RegisterFlagCompletionFunc(authfileFlagName, completion.AutocompleteDefault)

docs/source/markdown/podman-push.1.md

@@ -47,6 +47,10 @@ $ podman push myimage oci-archive:/tmp/myimage
 
 ## OPTIONS
 
+#### **--all-tags**, **-a**
+
+Push all tags for a given image to the repository. When using this flag, do not specify a tag for the DESTINATION.
+
 #### **--authfile**=*path*
 
 Path of the authentication file. Default is ${XDG\_RUNTIME\_DIR}/containers/auth.json, which is set using `podman login`.
@@ -121,6 +125,10 @@ This example pushes the image specified by the imageID to a container registry n
 
  `# podman push imageID docker://registry.example.com/repository:tag`
 
+This example pushes all tags for the image specified by the imageID to a container registry named registry.example.com
+
+`# podman push --all-tags imageID docker://registry.example.com/repository`
+
 This example pushes the image specified by the imageID to a container registry named registry.example.com and saves the digest in the specified digestfile.
 
  `# podman push --digestfile=/tmp/mydigest imageID docker://registry.example.com/repository:tag`

pkg/domain/infra/abi/images.go

@@ -305,6 +305,7 @@ func (ir *ImageEngine) Push(ctx context.Context, source string, destination stri
 	pushOptions.RemoveSignatures = options.RemoveSignatures
 	pushOptions.SignBy = options.SignBy
 	pushOptions.InsecureSkipTLSVerify = options.SkipTLSVerify
+	pushOptions.AllTags = options.All
 
 	compressionFormat := options.CompressionFormat
 	if compressionFormat == "" {

test/e2e/push_test.go

@@ -117,14 +117,18 @@ var _ = Describe("Podman push", func() {
 		push.WaitWithDefaultTimeout()
 		Expect(push).Should(Exit(0))
 
+		pushA := podmanTest.Podman([]string{"push", "-q", "-a", "--tls-verify=false", "--remove-signatures", ALPINE, "localhost:5000/my-alpine"})
+		pushA.WaitWithDefaultTimeout()
+		Expect(pushA).Should(Exit(0))
+
 		SkipIfRemote("Remote does not support --digestfile")
 		// Test --digestfile option
-		push2 := podmanTest.Podman([]string{"push", "--tls-verify=false", "--digestfile=/tmp/digestfile.txt", "--remove-signatures", ALPINE, "localhost:5000/my-alpine"})
-		push2.WaitWithDefaultTimeout()
+		pushD := podmanTest.Podman([]string{"push", "--tls-verify=false", "--digestfile=/tmp/digestfile.txt", "--remove-signatures", ALPINE, "localhost:5000/my-alpine"})
+		pushD.WaitWithDefaultTimeout()
 		fi, err := os.Lstat("/tmp/digestfile.txt")
 		Expect(err).To(BeNil())
 		Expect(fi.Name()).To(Equal("digestfile.txt"))
-		Expect(push2).Should(Exit(0))
+		Expect(pushD).Should(Exit(0))
 	})
 
 	It("podman push to local registry with authorization", func() {