-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] man pages: replace -c with --cpu-shares #14915
[CI:DOCS] man pages: replace -c with --cpu-shares #14915
Conversation
Signed-off-by: Erik Sjölund <[email protected]>
-c and --cpu-shares are the same, although having these use --cpu-shares is easier for humans to understand. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eriksjolund, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It seems the man pages don't mention -c podman/docs/source/markdown/podman-run.1.md Line 223 in edbfbfc
Should I add that? |
-c is not mentioned here either
|
Indeed you are right. Looks like you have found a compatibility issue.
|
@edsantiago sorry, I wasn't clear. I wasn't looking to get them all removed at this point, a fun weekend project for me. What I was wondering if there's a new " you " added in PR for the man pages, just the ones that live in https://github.com/containers/podman/tree/main/docs/source/markdown, then the CI would throw a warning or perhaps fail. Pronouns in readme's, tutorials, and other docs are fine. We just want to keep the man pages crisp and sans pronouns, or at least " you ". |
That would require running |
@edsantiago no worries at all, I was hoping it might be quick and easy. Thanks! |
9e61ee3
to
9ea32f2
Compare
@eriksjolund You have whitespace issues, and then we can merge. |
Signed-off-by: Erik Sjölund <[email protected]>
9ea32f2
to
1392922
Compare
whitespace now removed |
/lgtm |
These three man pages have some similar text.
podman/docs/source/markdown/podman-run.1.md
Lines 247 to 256 in edbfbfc
podman/docs/source/markdown/podman-create.1.md
Lines 231 to 239 in edbfbfc
podman/docs/source/markdown/podman-container-clone.1.md
Lines 91 to 99 in edbfbfc
I assume podman-run.1.md is the correct one (i.e. using --cpu-shares= instead of -c=)
Signed-off-by: Erik Sjölund [email protected]
Does this PR introduce a user-facing change?