Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] man pages: remove non-existent option builtin-volume #14911

Conversation

eriksjolund
Copy link
Contributor

Closes #14906

Signed-off-by: Erik Sjölund [email protected]

Does this PR introduce a user-facing change?

None

@rhatdan
Copy link
Member

rhatdan commented Jul 12, 2022

LGTM

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edsantiago Is this something your man page validation script could catch in the future?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eriksjolund, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2022
@Luap99
Copy link
Member

Luap99 commented Jul 12, 2022

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2022
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rhatdan
Copy link
Member

rhatdan commented Jul 12, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2022
@rhatdan rhatdan merged commit edbfbfc into containers:main Jul 12, 2022
@edsantiago
Copy link
Member

@edsantiago Is this something your man page validation script could catch in the future?

Sigh. The script was designed to catch that, but two subtleties in the way the man page was written:

#### **--image-volume**, **builtin-volume**=*bind|tmpfs|ignore*
                           ^-- no dashes         ^-----^---- or-signs

...made my script ignore that portion. I'm now looking into a way to fix that by being stricter.

@eriksjolund eriksjolund deleted the remove_builtin_volume_option_from_man_pages branch July 27, 2022 04:15
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The command-line option builtin-volume mentioned in podman-create.1.md does not exist
5 participants