-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] Add socket_activation.md #14909
[CI:DOCS] Add socket_activation.md #14909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @eriksjolund!
A side-note: @rhatdan and I was discussing the possibility to create a related blog post for Here is my initial attempt: I also wrote another text |
@eriksjolund you've been rocking the tutorials of late. Can you also please update the README.md with links to the new tutorials and a small description of each? |
64d4943
to
7e95e7f
Compare
7e95e7f
to
bd4e066
Compare
I added a link to the socket activation tutorial. (I'll wait with adding a link to the performance tutorial because I don't know how long it will take to finish it) Another thing. I modified this PR to build a local HTTPD container instead of of using ghcr.io/eriksjolund/socket-activate-httpd. The reason is that I wanted to avoid the responsibility to keep that container image up to date to the latest security fixes in HTTPD. |
b9534e2
to
3d083b1
Compare
First I thought I should write something about the need to use the Linux operating system to be able to use socket activation. I remove the draft status. |
0cc8bf2
to
1563f0e
Compare
Closes containers#14908 Signed-off-by: Erik Sjölund <[email protected]>
Co-authored-by: Valentin Rothberg <[email protected]> Signed-off-by: Erik Sjölund <[email protected]>
1563f0e
to
8e2add7
Compare
LGTM and thanks @eriksjolund |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eriksjolund, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@rhatdan Yesterday I split out the tutorial about using the systemd directive RestrictAddressFamilies I rewrote the potential RedHat blog a bit. (I removed the SELinux part and instead discussed privileges in more general terms). |
Closes #14908
Signed-off-by: Erik Sjölund [email protected]
Does this PR introduce a user-facing change?