Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Add socket_activation.md #14909

Merged

Conversation

eriksjolund
Copy link
Contributor

Closes #14908

Signed-off-by: Erik Sjölund [email protected]

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 12, 2022
@eriksjolund eriksjolund changed the title [WIP][CI:DOCS] Add podman-socket-activation.md [WIP] [CI:DOCS] Add podman-socket-activation.md Jul 12, 2022
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/tutorials/podman-socket-activation.md Outdated Show resolved Hide resolved
@eriksjolund
Copy link
Contributor Author

eriksjolund commented Jul 12, 2022

A side-note:

@rhatdan and I was discussing the possibility to create a related blog post for
https://www.redhat.com/sysadmin/topics/containers

Here is my initial attempt:
https://github.com/eriksjolund/podman-socket-activation/blob/rework_text/blog.md
(For me it would be fine to be a co-author too if you want to modify it)

I also wrote another text
https://github.com/eriksjolund/podman-socket-activation/blob/rework_text/RestrictAddressFamilies.md
(that might be too avant garde for a redhat blog or the podman web page)

@TomSweeneyRedHat
Copy link
Member

@eriksjolund you've been rocking the tutorials of late. Can you also please update the README.md with links to the new tutorials and a small description of each?

@eriksjolund eriksjolund force-pushed the add_socket_activation_tutorial branch from 64d4943 to 7e95e7f Compare July 13, 2022 11:56
@eriksjolund eriksjolund changed the title [WIP] [CI:DOCS] Add podman-socket-activation.md [WIP] [CI:DOCS] Add socket_activation.md Jul 13, 2022
@eriksjolund eriksjolund force-pushed the add_socket_activation_tutorial branch from 7e95e7f to bd4e066 Compare July 13, 2022 12:03
@eriksjolund
Copy link
Contributor Author

@eriksjolund you've been rocking the tutorials of late. Can you also please update the README.md with links to the new tutorials and a small description of each?

I added a link to the socket activation tutorial. (I'll wait with adding a link to the performance tutorial because I don't know how long it will take to finish it)

Another thing. I modified this PR to build a local HTTPD container instead of of using ghcr.io/eriksjolund/socket-activate-httpd. The reason is that I wanted to avoid the responsibility to keep that container image up to date to the latest security fixes in HTTPD.

@eriksjolund eriksjolund force-pushed the add_socket_activation_tutorial branch 6 times, most recently from b9534e2 to 3d083b1 Compare July 13, 2022 13:52
@eriksjolund eriksjolund marked this pull request as ready for review July 13, 2022 14:01
@eriksjolund
Copy link
Contributor Author

eriksjolund commented Jul 13, 2022

First I thought I should write something about the need to use the Linux operating system to be able to use socket activation.
I had difficulties coming up with a text about that so I just skipped that part.
Maybe it's possible to use Windows or Mac with a Linux VM that use VSOCK?
I'm a little confused about the topic so I skipped writing about that too.

I remove the draft status.

@eriksjolund eriksjolund changed the title [WIP] [CI:DOCS] Add socket_activation.md [CI:DOCS] Add socket_activation.md Jul 13, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 13, 2022
@eriksjolund eriksjolund force-pushed the add_socket_activation_tutorial branch 8 times, most recently from 0cc8bf2 to 1563f0e Compare July 14, 2022 13:16
Co-authored-by: Valentin Rothberg <[email protected]>
Signed-off-by: Erik Sjölund <[email protected]>
@eriksjolund eriksjolund force-pushed the add_socket_activation_tutorial branch from 1563f0e to 8e2add7 Compare July 14, 2022 13:21
@TomSweeneyRedHat
Copy link
Member

LGTM and thanks @eriksjolund
I'd like to have a head nod from @vrothberg

@rhatdan
Copy link
Member

rhatdan commented Jul 15, 2022

/approve
LGTM
@eriksjolund Great work. Did you ever publish the full blogs?
We can wait for @vrothberg to merge.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eriksjolund, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2022
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2022
@openshift-ci openshift-ci bot merged commit b4c09be into containers:main Jul 15, 2022
@eriksjolund
Copy link
Contributor Author

@eriksjolund Great work. Did you ever publish the full blogs?

@rhatdan Yesterday I split out the tutorial about using the systemd directive RestrictAddressFamilies
into the new GitHub repository https://github.com/eriksjolund/podman-RestrictAddressFamilies
On Monday or Tuesday I plan to write to tweet about it and also about the new Podman socket activation tutorial

I rewrote the potential RedHat blog a bit. (I removed the SELinux part and instead discussed privileges in more general terms).
Do you think the blog could be published under https://www.redhat.com/sysadmin/topics/containers ?
If so, how should I proceed?

@eriksjolund eriksjolund deleted the add_socket_activation_tutorial branch July 27, 2022 04:21
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Podman socket activation tutorial
4 participants