Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] rootless_tutorial: Remove incorrect advice regarding volume… #14905

Merged

Conversation

eriksjolund
Copy link
Contributor

…s and mount points

  • Remove the instructions
    "You should always give the full path to the volume you'd like to mount"
    "The mount point must exist in the container"
    as they are incorrect as shown by this example
    $ mkdir dir1
    $ podman run --rm -v ./dir1:/dir1:Z docker.io/library/fedora:36 touch /dir1/file
    $ ls dir1
    file
    $ podman run --rm docker.io/library/fedora:36 ls -l /dir1
    ls: cannot access '/dir1': No such file or directory
    $ podman --version
    podman version 4.1.1
    $
    

Signed-off-by: Erik Sjölund [email protected]

Does this PR introduce a user-facing change?

None

@rhatdan
Copy link
Member

rhatdan commented Jul 12, 2022

$ podman run --rm -v ./dir1:/dir1:Z docker.io/library/fedora:36 touch /dir1/file
Works BUT
$ podman run --rm -v dir1:/dir1:Z docker.io/library/fedora:36 touch /dir1/file
Will have a very different result, and this should be pointed out. Basically the volume needs to be a full path or begin with a . or ../

@eriksjolund eriksjolund force-pushed the remove_rootless_considerations branch 2 times, most recently from ade9e1b to 1c96a0b Compare July 12, 2022 14:16
@eriksjolund
Copy link
Contributor Author

I added one of the advices back (now also mentioning relative paths starting with a dot).

@eriksjolund eriksjolund force-pushed the remove_rootless_considerations branch from 1c96a0b to 8c14f91 Compare July 12, 2022 14:21
…s and mount points

* Remove the instruction
  "The mount point must exist in the container"
  as it is incorrect which is shown by this example
  ```
  $ mkdir dir1
  $ podman run --rm -v ./dir1:/dir1:Z docker.io/library/fedora:36 touch /dir1/file
  $ ls dir1
  file
  $ podman run --rm docker.io/library/fedora:36 ls -l /dir1
  ls: cannot access '/dir1': No such file or directory
  $ podman --version
  podman version 4.1.1
  $
  ```

* Rewrite the advice "You should always give the full path to the volume you'd like to mount"
  so that it also mentions relative paths starting with a dot.

Signed-off-by: Erik Sjölund <[email protected]>
@eriksjolund eriksjolund force-pushed the remove_rootless_considerations branch from 8c14f91 to b8a7e27 Compare July 12, 2022 14:32
@TomSweeneyRedHat
Copy link
Member

LGTM
@rhatdan is your concern addressed?

@rhatdan
Copy link
Member

rhatdan commented Jul 12, 2022

/approve
/lgtm
Thanks @eriksjolund

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eriksjolund, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2022
@openshift-ci openshift-ci bot merged commit 72d13c5 into containers:main Jul 12, 2022
@eriksjolund eriksjolund deleted the remove_rootless_considerations branch July 27, 2022 04:23
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants