Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Add performance tutorial #14903

Merged

Conversation

eriksjolund
Copy link
Contributor

Signed-off-by: Erik Sjölund [email protected]

Closes #14902

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 12, 2022
@eriksjolund
Copy link
Contributor Author

I wrote a very sketchy draft.
Currently it's very far from being finished.

@eriksjolund eriksjolund force-pushed the add_performance_doc branch 5 times, most recently from 7721196 to b20b1c3 Compare July 12, 2022 10:20
@TomSweeneyRedHat
Copy link
Member

The bane of my existence, trailing white spaces! Other than that, LGTM. You might consider having this published on the Enable Sysadmin website too, they'd probably be happy to have it.

@eriksjolund
Copy link
Contributor Author

@TomSweeneyRedHat Whitespaces now removed. The document is more of a sketch right now.
I'm adding some ideas for how such a performance document could look like.

@vrothberg
Copy link
Member

@TomSweeneyRedHat PTanotherL

@eriksjolund
Copy link
Contributor Author

I copied in some old text from https://github.com/eriksjolund/using-podman-quick-instructions#example-fedora--speed-up-podman-build-by-reusing-the-dnf-metadata-cache without much thought. My plan was to clean this up a bit. I could take a look over the weekend.

@eriksjolund eriksjolund force-pushed the add_performance_doc branch 8 times, most recently from 20cee6b to 7f98b04 Compare August 8, 2022 05:07
@eriksjolund eriksjolund force-pushed the add_performance_doc branch 3 times, most recently from d9ec7b4 to ceeca36 Compare August 14, 2022 17:38
@eriksjolund
Copy link
Contributor Author

The document is still a work-in-progress. I'm still a bit clueless about what type of contents is meaningful to include. I would like to avoid adding information that should be better placed in a more specific document such as basic_networking.md or socket_activation.md.


A side-note: I moved some text out of this PR into
https://github.com/eriksjolund/podman/blob/performance.md_extra_text/docs/tutorials/performance_unused_text.md

The moved text was a mix of

  • too obvious
  • too general (building smaller containers)
  • too much a special case (using :U volume flag)

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Sep 14, 2022

@eriksjolund any update?

@rhatdan rhatdan removed the stale-pr label Sep 14, 2022
@eriksjolund eriksjolund force-pushed the add_performance_doc branch 2 times, most recently from 5e7fe43 to 9db0ebe Compare September 15, 2022 18:08
@eriksjolund
Copy link
Contributor Author

Please suggest removal of text and sections that could be skipped.
I'm really not convinced that all of the text belong in such a document.

I remove the draft status of the PR.

@eriksjolund eriksjolund marked this pull request as ready for review September 15, 2022 19:05
@eriksjolund eriksjolund changed the title [WIP] [CI:DOCS] Add performance tutorial [CI:DOCS] Add performance tutorial Sep 15, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2022
@vrothberg
Copy link
Member

@rhatdan are we good to go?

Apologies @eriksjolund, this one fell under the radar.

@eriksjolund
Copy link
Contributor Author

@vrothberg no worries. Feel free to merge, if you think the text makes sense. Also feel free to close the PR or make major additions/changes/deletions. I don't mind if you make major changes as I believe the document could be improved a lot with input from others.

Reuse part of the description of --network=host from /docs/source/markdown/podman-run.1.md.in

Signed-off-by: Erik Sjölund <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Nov 9, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eriksjolund, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2022
@openshift-merge-robot openshift-merge-robot merged commit 3e811ac into containers:main Nov 9, 2022
@eriksjolund eriksjolund deleted the add_performance_doc branch November 19, 2022 13:57
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Podman performance tips tutorial
5 participants