Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] podman-info.1.md: update examples (now also shell completion and jq) #14887

Merged

Conversation

eriksjolund
Copy link
Contributor

  • Add example "Extracting the list of container registries with a Go template".
    (The example was already present but in a much shorter form)

  • Add example "Extracting the list of container registries from JSON with jq".

  • Add shell completion instructions

Signed-off-by: Erik Sjölund [email protected]

Does this PR introduce a user-facing change?

None

* Add example "Extracting the list of container registries with a Go template".
  (The example was already present but in a much shorter form)

* Add example "Extracting the list of container registries from JSON with jq".

* Add shell completion instructions

Signed-off-by: Erik Sjölund <[email protected]>
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2022
@eriksjolund
Copy link
Contributor Author

eriksjolund commented Jul 11, 2022

The extra newline in the end of the output

 $ podman info -f '{{range index .Registries "search"}}{{.}}\n{{end}}'
 registry.fedoraproject.org
 registry.access.redhat.com
 docker.io
 quay.io

$

is a bit unfortunate.

@vrothberg
Copy link
Member

The extra newline in the end of the output [...] is a bit unfortunate.

Would you open an issue or (even better) a PR for it?

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks a lot!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eriksjolund, flouthoc, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2022
@eriksjolund
Copy link
Contributor Author

The extra newline in the end of the output [...] is a bit unfortunate.

Would you open an issue or (even better) a PR for it?

I created an issue

@vrothberg
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2022
@openshift-ci openshift-ci bot merged commit 3691c9b into containers:main Jul 11, 2022
@eriksjolund eriksjolund deleted the podman_info_command_completion_doc branch July 27, 2022 04:35
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants