kill: record exit code #14821
kill: record exit code #14821
Conversation
Make sure to record the exit code after killing a container. Otherwise, a concurrent `stop` may not record the exit code and yield the container unusable. Fixes: containers#14761 Signed-off-by: Valentin Rothberg <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| c.newContainerEvent(events.Kill) | ||
|
|
||
| return c.save() | ||
| return c.recordExitCode() |
There was a problem hiding this comment.
podman kill can be used to send any signal to the container, unless I am missing something c.recordExitCode() would block and wait for conmon to exit which seems wrong. Am I missing something?
There was a problem hiding this comment.
Oh, that is a fair point. I'll check what I can do.
There was a problem hiding this comment.
Conmon spawns the cleanup process, that should record the exit code IMO and not kill.
There was a problem hiding this comment.
I concur. It seems there are still some farts in the current logic. Will continue digging tomorrow.
|
Closing as it's not the right way to go. |
github-actions
bot
added
the
locked - please file new issue/PR
Make sure to record the exit code after killing a container.
Otherwise, a concurrent
stopmay not record the exit codeand yield the container unusable.
Fixes: #14761
Signed-off-by: Valentin Rothberg [email protected]
Does this PR introduce a user-facing change?
No release note as it's fixing a bug that never made it into any version.
@mheon @baude PTAL