api,images: add support for LookupManifest to Image removal REST API
#14783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
flouthoc
force-pushed
the
api-image-lookup-manifest
branch
3 times, most recently
from
cceaeaf to
1672024
Compare
vrothberg
reviewed
Jun 30, 2022
flouthoc
force-pushed
the
api-image-lookup-manifest
branch
from
1672024 to
72c347d
Compare
ImagesBatchRemoval and ImageRemoval now honors and accepts `LookupManifest` parameter which further tells libimage to resolve to manifest list if it exists instead of actual image. Following PR also makes `podman-remote manifest rm` functional which was broken till now. Closes: containers#14763 Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
api-image-lookup-manifest
branch
from
72c347d to
7bbfb3e
Compare
|
Restarted failing test looked unrelated to the PR in the first instance. @vrothberg PTAL |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImagesBatchRemoval and ImageRemoval now honors and accepts
LookupManifestparameter which further tells libimage to resolve tomanifest list if it exists instead of actual image.
Following PR also makes
podman-remote manifest rmfunctional which wasbroken till now.
Closes: #14763
Does this PR introduce a user-facing change?