--userns=keep-id,nomap are not allowed in rootful mode #14532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Luap99
reviewed
Jun 8, 2022
test/system/170-run-userns.bats
Outdated
| baseuid=$(egrep "${ns_user}:" /etc/subuid | cut -f2 -d:) | ||
| test ! -z ${baseuid} || skip "no IDs allocated for user ${ns_user}" | ||
| if is_rootless; then | ||
| ns_user=$(id -un) |
test/system/170-run-userns.bats
Outdated
| run_podman rm -t 0 --force ${cid} | ||
| @test "podman userns=keep-id" { | ||
| if is_rootless; then | ||
| user=$(id -u) |
There was a problem hiding this comment.
Looked fine in Emacs, but it looks like tabs versus spaces. Fixed.
openshift-ci
bot
added
the
approved
Signed-off-by: Daniel J Walsh <[email protected]>
|
/lgtm |
|
The Openshift bot doesn't seem to be monitoring this, but hopefully adding LGTM will wake it |
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Sep 7, 2022
Another easy one. Difference is that pod-create was fixed in containers#14532 (s/ignore/not allowed/) but pod-clone was not. I went with the fixed version. Signed-off-by: Ed Santiago <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel J Walsh [email protected]
Does this PR introduce a user-facing change?
No