-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system test image: bump to 20220615 #14529
system test image: bump to 20220615 #14529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but it looks like the podman run --tz
test needs to be updated as well.
e9fc656
to
94ebe3e
Compare
/lgtm |
This (like everything else in this PR) was much more complicated than I had expected. TL;DR my two-stage build solved this, but that broke the That may have been the longest TL;DR I've ever written. Sorry. |
Okay, looks like I really need to look into this |
Filed #14536 |
Changes: - use --timestamp option to produce 'created' stamps that can be reliably tested in the image-history test - podman now supports manifest & multiarch run, so we no longer need buildah - bump up base alpine & busybox images This turned out to be WAY more complicated than it should've been, because: - alpine 3.14 fixed 'date -Iseconds' to include a colon in the TZ offset ("-07:00", was "-0700"). This is now consistent with GNU date's --iso-8601 format, yay, so we can eliminate a minor workaround. - with --timestamp, all ADDed files are set to that timestamp, including the custom-reference-timestamp file that many tests rely on. So we need to split the build into two steps. But: - ...with a two-step build I need to use --squash-all, not --squash, but: - ... (deep sigh) --squash-all doesn't work with --timestamp (containers#14536) so we need to alter existing tests to deal with new image layers. - And, long and sordid story relating to --rootfs. TL;DR that option only worked by a miracle relating to something special in one specific test image; it doesn't work with any other images. Fix seems to be complicated, so we're bypassing with a FIXME (containers#14505). And, unrelated: - remove obsolete skip and workaround in run-basic test (dating back to varlink days) - add a pause-image cleanup to avoid icky red warnings in logs Fixes: containers#14456 Signed-off-by: Ed Santiago <[email protected]>
94ebe3e
to
0a202a9
Compare
@containers/podman-maintainers this is ready. As a reminder, it was supposed to be a five-minute fix for test failures seen by the multiarch team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Changes:
use --timestamp option to produce 'created' stamps
that can be reliably tested in the image-history test
podman now supports manifest & multiarch run, so we
no longer need buildah
bump up base alpine & busybox images
This turned out to be WAY more complicated than it should've been,
because:
alpine 3.14 fixed 'date -Iseconds' to include a colon in
the TZ offset ("-07:00", was "-0700"). This is now consistent
with GNU date's --iso-8601 format, yay, so we can eliminate
a minor workaround.
with --timestamp, all ADDed files are set to that timestamp,
including the custom-reference-timestamp file that many tests
rely on. So we need to split the build into two steps. But:
...with a two-step build I need to use --squash-all, not --squash, but:
... (deep sigh) --squash-all doesn't work with --timestamp (build with --squash-all + --timestamp clobbers timestamps in preexisting layers #14536)
so we need to alter existing tests to deal with new image layers.
And, long and sordid story relating to --rootfs. TL;DR that option
only worked by a miracle relating to something special in one
specific test image; it doesn't work with any other images. Fix
seems to be complicated, so we're bypassing with a FIXME (Unhealthy pod(created via podman play kube) doesn't restart #14505).
And, unrelated:
back to varlink days)
Fixes: #14456
Signed-off-by: Ed Santiago [email protected]