podman cp: do not overwrite non-dirs with dirs and vice versa

[vrothberg]

Add a new --overwrite flag to podman cp to allow for overwriting in
case existing users depend on the behavior; they will have a workaround.
By default, the flag is turned off to be compatible with Docker and to
have a more sane behavior.

Fixes: #14420
Signed-off-by: Valentin Rothberg [email protected]

Does this PR introduce a user-facing change?

Fix a bug where `podman cp` would overwrite directories with non-directories and vice versa.  A new `--overwrite` flag allows for opting into the old behavior if needed.

@Luap99 @mheon @jwhonce PTAL

[Luap99]

I think the API still defaults to overwrite, at least I see no changes in here for that.

[vrothberg]

Added more tests but just noticed that the remote errors don't work as expected.

[vrothberg]

@flouthoc the recent buildah changes are biting my butt. Should the logfile test be skipped on remote? I don't see --logfile being plugged into remote.

[vrothberg]

[+0543s] not ok 112 bud-logfile-with-split-logfile-by-platform
[+0543s] # (from function `assert' in file tests/helpers.bash, line 465,
[+0543s] #  from function `expect_output' in file tests/helpers.bash, line 492,
[+0543s] #  in test file tests/bud.bats, line 1722)
[+0543s] #   `expect_output --substring "FROM alpine"' failed
[+0543s] # /var/tmp/go/src/github.com/containers/podman/test-buildah-v1.26.1-0.20220607182634-005447be07ee/tests /var/tmp/go/src/github.com/containers/podman/test-buildah-v1.26.1-0.20220607182634-005447be07ee
[+0543s] # $ podman build --force-rm=false --layers=false --logfile /var/tmp/buildah_tests.dvbiqm/logfile --logsplit --platform linux/arm64,linux/amd64 --signature-policy /var/tmp/go/src/github.com/containers/podman/test-buildah-v1.26.1-0.20220607182634-005447be07ee/tests/policy.json /var/tmp/buildah_tests.dvbiqm/my-dir
[+0543s] # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
[+0543s] # #|     FAIL: podman build --force-rm=false --layers=false --logfile /var/tmp/buildah_tests.dvbiqm/logfile --logsplit --platform linux/arm64,linux/amd64 --signature-policy /var/tmp/go/src/github.com/containers/podman/test-buildah-v1.26.1-0.20220607182634-005447be07ee/tests/policy.json /var/tmp/buildah_tests.dvbiqm/my-dir
[+0543s] # #| expected: =~ 'FROM alpine'
[+0543s] # #|   actual:    'cat: /var/tmp/buildah_tests.dvbiqm/logfile_linux_arm64: No such file or directory'
[+0543s] # #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[+0543s] # /var/tmp/go/src/github.com/containers/podman/test-buildah-v1.26.1-0.20220607182634-005447be07ee

[flouthoc]

@vrothberg It would need implementation on API end. Yes please feel free to skip it for now and i'll pick it up in a followup.

[vrothberg]

@vrothberg It would need implementation on API end. Yes please feel free to skip it for now and i'll pick it up in a followup.

Does it make sense for remote? The file should ultimately be written on the client-side ... I guess

[flouthoc]

@vrothberg It would need implementation on API end. Yes please feel free to skip it for now and i'll pick it up in a followup.

Does it make sense for remote? The file should ultimately be written on the client-side ... I guess

@vrothberg Umm.. I am confused 😕 as of now since i don't see a skip for bud-logfile so I am assuming it works for remote and writes all the downloaded logs to client side so --logsplit should work as well in theory but it would be too much of a new implementation on client side and API end to make it work. So even if it happens or does not happens it looks like too big of a change to happen in this PR.

@vrothberg On the podman man-page could we add that --logsplit is not supported on remote as of now.

[vrothberg]

Ready to merge. @flouthoc @Luap99 PTAL

[flouthoc]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [flouthoc,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vrothberg]

@rhatdan PTAL

[rhatdan]

/lgtm

[Luap99]

Why is the error message different? We should return a reasonable error for the remote client.

[vrothberg]

We send 200 before (and hence can't overwrite the code) and use the ResponseWriter as the writer. To fix it, we should probably copy the archive to a temporary file and then copy that over the wire.