Rename all references to kpod to podman #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM assuming happy tests. Hard to tell if any were missed. I say press the merge button while looking between your fingers. I'd also suggest holding the merge to Monday morn. Murphy lets the chances go up exponentially for problems from PR's like this on a Friday night. |
mheon
reviewed
Dec 16, 2017
| | [kpod-unpause(1)](/docs/kpod-unpause.1.md) | Unpause one or more running containers |[](https://asciinema.org/a/141292)| | ||
| | [kpod-version(1)](/docs/kpod-version.1.md) | Display the version information |[](https://asciinema.org/a/mfrn61pjZT9Fc8L4NbfdSqfgu)| | ||
| | [kpod-wait(1)](/docs/kpod-wait.1.md) | Wait on one or more containers to stop and print their exit codes|| | ||
| | [podman(1)](/docs/podman.1.md) | Simple management tool for pods and images || |
There was a problem hiding this comment.
No need to make changes in vendor/
We should get a PR into CRI-O to fix readme and transfer there and revendor to remove the last few mentions
|
One extra file in vendor got added otherwise LGTM |
rhatdan
force-pushed
the
podman
branch
4 times, most recently
from
e72819f to
7951f88
Compare
Remove or comment out unused functions. Signed-off-by: Daniel J Walsh <[email protected]>
|
LGTM |
The decision is in, kpod is going to be named podman. Signed-off-by: Daniel J Walsh <[email protected]>
|
@rh-atomic-bot r=umohnani8 |
|
📌 Commit 1e1e998 has been approved by |
|
⚡ Test exempted: pull fully rebased and already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Dec 18, 2017
The decision is in, kpod is going to be named podman. Signed-off-by: Daniel J Walsh <[email protected]> Closes: #145 Approved by: umohnani8
afbjorklund
added a commit
to afbjorklund/minikube
that referenced
this pull request
Jul 29, 2018
Simple management tool for containers and images "podman shares state with crio and so has the capability to debug pods/images created by crio" containers/podman#145
afbjorklund
added a commit
to afbjorklund/minikube
that referenced
this pull request
Jul 30, 2018
Simple management tool for containers and images "podman shares state with crio and so has the capability to debug pods/images created by crio" containers/podman#145
dlorenc
pushed a commit
to kubernetes/minikube
that referenced
this pull request
Jul 30, 2018
Simple management tool for containers and images "podman shares state with crio and so has the capability to debug pods/images created by crio" containers/podman#145
baude
pushed a commit
to baude/podman
that referenced
this pull request
Aug 31, 2019
Pass interface name and MAC back to runtime
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.