image list: do not reformat .CreatedAt
#14476
Conversation
As shown in containers#14456, the `.CreatedAt` fields for `image list` and of `image history` can differ by one. The discussed theory is that the off-by-one is caused by rounding. Indeed, the field of `image list` is reformatted. `image history` is returning the UNIX time; just as the `.CreatedAt` field should. I am unable to create a reproducer for the issue but double-checked what the docker client does: return the UNIX time. [NO NEW TESTS NEEDED] Fixes: containers#14456 Signed-off-by: Valentin Rothberg <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
I took a minute to pull & make your PR, and try my reproducer, and I see no difference. This still gives off-by-one timestamps between |
Dang. I tried with Docker and it suffers from the same problem. |
|
/hold Requires more digging. The change itself here is sound but not sufficient. |
openshift-ci
bot
added
the
do-not-merge/hold
|
OK, I am going to close. I'll drop a comment in the issue. |
github-actions
bot
added
the
locked - please file new issue/PR
As shown in #14456, the
.CreatedAtfields forimage listand ofimage historycan differ by one. The discussed theory is that theoff-by-one is caused by rounding.
Indeed, the field of
image listis reformatted.image historyisreturning the UNIX time; just as the
.CreatedAtfield should.I am unable to create a reproducer for the issue but double-checked
what the docker client does: return the UNIX time.
[NO NEW TESTS NEEDED]
Fixes: #14456
Signed-off-by: Valentin Rothberg [email protected]
Does this PR introduce a user-facing change?
@edsantiago @rhatdan PTAL