Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4.0-rhel] Bump c/image v1.38.4, c/storage v5.19.4 #14440

Merged
merged 1 commit into from
Jun 2, 2022
Merged

[v4.0-rhel] Bump c/image v1.38.4, c/storage v5.19.4 #14440

merged 1 commit into from
Jun 2, 2022

Conversation

TomSweeneyRedHat
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat commented Jun 1, 2022 •
edited by rhatdan
Loading

As the title says.

Bump c/image to v1.38.4 and c/storage to v5.19.4.

[NO NEW TESTS NEEDED]

This partially addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2072452

Signed-off-by: tomsweeneyredhat [email protected]

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

@TomSweeneyRedHat: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Jun 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2022
@vrothberg
Copy link
Member

The branch seems broken:

Running golangci-lint for tunnel
Build Tags tunnel: apparmor,seccomp,selinux,linter,remote,remoteclient
Skipped directories tunnel: pkg/api
hack/golangci-lint.sh: line 24: ./bin/golangci-lint: No such file or directory

@Luap99, can you take a look?

@Luap99
Copy link
Member

Luap99 commented Jun 1, 2022

I think you have to backport e5a86d2

@TomSweeneyRedHat
[v4.0-rhel] Bump c/image v1.38.4, c/storage v5.19.4
be766d5 
As the title says.

Bump c/image to v1.38.4 and c/storage to v5.19.4.
Also backport containers@e5a86d2
for golang ci support.

[NO NEW TESTS NEEDED]

This partially addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2072452

Signed-off-by: tomsweeneyredhat <[email protected]>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/bumpthecs branch from 1574468 to be766d5 Compare June 2, 2022 00:18
@TomSweeneyRedHat
Copy link
Member Author

@Luap99 TYVM for the tip, I've included that too.

vrothberg
vrothberg reviewed Jun 2, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mheon @Luap99 PTAL

@rhatdan
Copy link
Member

rhatdan commented Jun 2, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2022
@rhatdan rhatdan removed the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Jun 2, 2022
@openshift-merge-robot openshift-merge-robot merged commit bfc8b36 into containers:v4.0-rhel Jun 2, 2022
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/bumpthecs branch June 30, 2023 21:48
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomSweeneyRedHat @vrothberg @Luap99 @rhatdan @openshift-merge-robot