Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed imageStream hardcoded value #14439

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Removed imageStream hardcoded value #14439

merged 1 commit into from
Jun 1, 2022

Conversation

jakecorrenti
Copy link
Member

@jakecorrenti jakecorrenti commented May 31, 2022 •
edited
Loading

[NO NEW TESTS NEEDED] Removed imageStream hard-coded value that was set to
testing. Since podman4 is in the fcos trees, it should be removed. The
respective comments have also been removed.

Signed-off-by: Jake Correnti [email protected]

Does this PR introduce a user-facing change?

None

@jakecorrenti jakecorrenti changed the title [NO NEW TESTS] Removed imageStream hardcoded value Removed imageStream hardcoded value May 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@jakecorrenti: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Luap99
Copy link
Member

Luap99 commented Jun 1, 2022

@baude PTAL

@rhatdan
Copy link
Member

rhatdan commented Jun 1, 2022

LGTM

@jakecorrenti
Copy link
Member Author

/assign @baude

@Luap99
Copy link
Member

Luap99 commented Jun 1, 2022

@jakecorrenti Could please squash the commits so that you only have one.

@mheon
Copy link
Member

mheon commented Jun 1, 2022

Concur on squash, otherwise LGTM
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakecorrenti, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2022
@jakecorrenti jakecorrenti force-pushed the remove-hardcoded-imageStream-line branch from 0965a87 to 2ee4c0d Compare June 1, 2022 15:32
Removed imageStream hardcoded value
dbdc26a 
[NO NEW TESTS NEEDED] Removed `imageStream` hardcoded value  that was set to
testing. Since podman4 is in the fcos trees, it should be removed. The
respective comments have also been removed.

Signed-off-by: Jake Correnti <[email protected]>
@jakecorrenti jakecorrenti force-pushed the remove-hardcoded-imageStream-line branch from 2ee4c0d to dbdc26a Compare June 1, 2022 15:45
@mheon
Copy link
Member

mheon commented Jun 1, 2022

LGTM on my end, @baude PTAL

@baude
Copy link
Member

baude commented Jun 1, 2022

Congratulations @jakecorrenti on your first Podman PR! Welcome to the team and we look forward to working with you.

@baude
Copy link
Member

baude commented Jun 1, 2022

/hold
/lgtm

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jun 1, 2022
@jakecorrenti
Copy link
Member Author

Congratulations @jakecorrenti on your first Podman PR! Welcome to the team and we look forward to working with you.

Thank you! I'm very excited to be working with you all

@cdoern
Copy link
Contributor

cdoern commented Jun 1, 2022

the failure is a flake, restarted the test

@mheon
Copy link
Member

mheon commented Jun 1, 2022

We're green, merging
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2022
@openshift-merge-robot openshift-merge-robot merged commit 2c63b8a into containers:main Jun 1, 2022
@jakecorrenti jakecorrenti deleted the remove-hardcoded-imageStream-line branch June 1, 2022 19:24
@edsantiago edsantiago mentioned this pull request Jun 2, 2022
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@baude baude

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jakecorrenti @Luap99 @rhatdan @mheon @baude @cdoern @openshift-merge-robot