Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API support for NoOverwriteDirNonDir #14393

Merged
merged 1 commit into from
May 27, 2022
Merged

Add API support for NoOverwriteDirNonDir #14393

merged 1 commit into from
May 27, 2022
+41 −28

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented May 26, 2022

Update method signatures and structs to pass option to buildah code

NONE

[NO NEW TESTS NEEDED]

Signed-off-by: Jhon Honce [email protected]

@jwhonce
Add API support for NoOverwriteDirNonDir
8efdbf5 
Update method signatures and structs to pass option to buildah code

```release-note
NONE
```

[NO NEW TESTS NEEDED]

Signed-off-by: Jhon Honce <[email protected]>
@jwhonce jwhonce added the kind/cleanup Categorizes issue or PR as related to cleanup. label May 26, 2022
@jwhonce jwhonce self-assigned this May 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2022
@rhatdan
Copy link
Member

rhatdan commented May 27, 2022

LGTM

1 similar comment
@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2022
@openshift-merge-robot openshift-merge-robot merged commit f48bf58 into containers:main May 27, 2022
@Luap99 Luap99 mentioned this pull request May 30, 2022
Closed
@vrothberg
Copy link
Member

vrothberg commented Jun 1, 2022 •
edited
Loading

#14420 suggests that we should add regression tests for this change.

@vrothberg
Copy link
Member

#14420 suggests that we should add regression tests for this change.

Yup. It only blocks dirs from being replaced with a file but not the vice versa. I'll add tests when fixing #14420.

This was referenced Jun 2, 2022
Closed
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jwhonce jwhonce

@TomSweeneyRedHat TomSweeneyRedHat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleanup. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jwhonce @rhatdan @TomSweeneyRedHat @vrothberg @openshift-merge-robot