Fix swagger model of InspectPodResponse
#14377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to add [NO NEW TESTS NEEDED] |
SoMuchForSubtlety
force-pushed
the
fix/pod-inspect-response
branch
2 times, most recently
from
3faf31a to
b6aa01b
Compare
|
@SoMuchForSubtlety could you rebase on current main please? The test failures are nasty flakes fixed in cb76d15. It'll be much easier to rebase & resubmit than for someone to press |
`net.IP` gets marshalled as `string` and not `[]uint8` [NO TESTS NEEDED] [NO NEW TESTS NEEDED] Signed-off-by: Jakob Ahrer <[email protected]>
SoMuchForSubtlety
force-pushed
the
fix/pod-inspect-response
branch
from
b6aa01b to
8c78141
Compare
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, SoMuchForSubtlety The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially addresses #14160 by fixing one instance of
net.IPbeing represented as[]uint8in the swagger API spec. This fix does not work for the following models, because they contain arrays ofnet.IP.ContainerNetworkConfig#dns_serverNetOptions#dns_serverNetworkConnectOptions#static_ipsPerNetworkOptions#static_ipsPodNetworkConfig#dns_serverPodSpecGenerator#dns_serverSpecGenerator#dns_serverDoes this PR introduce a user-facing change?