podman pod create --uidmap patch

[cdoern]

podmans remote API does not marshal infra's spec due to
the fact that if it did, all of those options would be available to
the users on the command line. This means we need to manually map "backwards"
some container spec items -> pod spec items before calling PodCreate, this was
one of them that was forgotten

This is a patch that will most likely be reverted (for a better solution) once the new API specgen format is implemented for pods.

resolves #14233

Signed-off-by: cdoern [email protected]

Does this PR introduce a user-facing change?

None

[rhatdan]

LGTM
Although I am not sure how/why this works.

[Luap99]

I think @vrothberg already added a test which should be enabled,

podman/test/system/170-run-userns.bats

Line 41 in 800a367

skip_if_remote "remote --uidmap is broken (see #14233)"

[Luap99]

I think @vrothberg already added a test which should be enabled,

podman/test/system/170-run-userns.bats

Line 41 in 800a367

skip_if_remote "remote --uidmap is broken (see #14233)"

[cdoern]

ah I see @vrothberg @Luap99, should i just rm that skip and maybe add an inspect to see if the infra ctr has the mappings?

[TomSweeneyRedHat]

LGTM
once you coordinate with @vrothberg

[vrothberg]

ah I see @vrothberg @Luap99, should i just rm that skip and maybe add an inspect to see if the infra ctr has the mappings?

Yes, that sounds good to me. Apologies for the late reply.

[cdoern]

@vrothberg PTAL

[rhatdan]

/approve

[vrothberg]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoern, rhatdan, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment