Allow podman pod create --share +pid #14333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
edsantiago
reviewed
May 24, 2022
test/system/200-pod.bats
Outdated
| @@ -335,8 +335,15 @@ EOF | |||
| is "$output" ".*Invalid kernel namespace to share: bogus. Options are: cgroup, ipc, net, pid, uts or none" \ | |||
| "pod test for bogus --share option" | |||
| run_podman pod create --share ipc --name $pod_name | |||
| run_podman pod inspect -l --format "{{.SharedNamespaces}}" | |||
There was a problem hiding this comment.
-l doesn't work on remote (hence the test failures). Can you change this and line 343 to use $pod_name instead? We already have other tests for -l
Fixes: containers#13422 Signed-off-by: Daniel J Walsh <[email protected]>
edsantiago
added
the
kind/feature
|
LGTM and tests are green. |
|
@containers/podman-maintainers PTAL |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13422
Signed-off-by: Daniel J Walsh [email protected]
Does this PR introduce a user-facing change?
No