compat, build: suppress step errors when quiet=1 is set

[flouthoc]

Match with docker API and suppress step errors when field quiet is set.

Closes: #14315

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [flouthoc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Romain-Geissler-1A]

Hi,

Thank you for fixing this so quickly !

Since I face this problem on a RHEL (8.6 and 9) with the official podman package, and since it seems to me that this fix isn't quite invaside/risky, would it be possible to also consider a backport in branch 4.0 and an official RHEL 8.6/9 podman package release as well ?

Cheers,
Romain

[flouthoc]

Hi,

Thank you for fixing this so quickly !

Since I face this problem on a RHEL (8.6 and 9) with the official podman package, and since it seems to me that this fix isn't quite invaside/risky, would it be possible to also consider a backport in branch 4.0 and an official RHEL 8.6/9 podman package release as well ?

Cheers, Romain

@Romain-Geissler-1A I am not sure if we could backport this or not afaik backports are usually critical bug-fixes but I think since its pretty straight-forward to backport this so maybe this could be picked up as backport candidate.

@mheon @rhatdan Would it be possible to consider this as backport candidate ?

[rhatdan]

No need for length check. For loop will not fire if len==0.

[flouthoc]

fixed :)

[mheon]

Please open a Bugzilla if you wish to have this backported - the backport process lives there.

[rhatdan]

LGTM

[flouthoc]

@jwhonce @mheon @rhatdan @nalind PTAL, tests are green.

[rhatdan]

@Romain-Geissler-1A Can you verify this fix works for you?

[Romain-Geissler-1A]

Hi,

I have started an image in privileged mode based on this Dockerfile https://github.com/containers/podman/blob/main/contrib/podmanimage/upstream/Dockerfile targetting this pull request, started the podman service, cloned my own code and tried running this command, and indeed it seems to work:

[root@6b50235f2201 src]# podman --remote run -t -i --rm "$(podman --remote build --quiet .)"
++ podman --remote build --quiet .
+ podman --remote run -t -i --rm 416e6679f8d104950683bcfbe591d552efd364a67e4ae4c05f7a124c4ef44c53

So as far as I can tell, yes it's validated on my side.

Note: it looks like this diff applies cleanly on branch "v4.0". I tried to rpmbuild it on a centos stream 8 image, but went into errors, so I haven't tried this on an actual RHEL 8, only in the above fedora privileged image.

Cheers,
Romain

[rhatdan]

/lgtm

[TomSweeneyRedHat]

Just for historical purposes, the backport BZ was opened here: https://bugzilla.redhat.com/show_bug.cgi?id=2089790