Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update c/image #14300

Merged
merged 1 commit into from
May 23, 2022
Merged

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented May 19, 2022

GitHub.com/proglottis/gpgme now uses pkg-config to find gpgme. That’s cleaner than the previous method, but test that Podman builds with that, just to avoid surprises (and this PR should fix them if there turn out to be any.)

Does this PR introduce a user-facing change?

Builds with GPGME now require GPGME ≥ 1.13.0.

... to bring in github.com/proglottis/gpgme 0.1.2 , and test
its new use of pkg-config to find gpgme.

Signed-off-by: Miloslav Trmač <[email protected]>
@openshift-ci openshift-ci bot added release-note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 19, 2022
@mtrmac
Copy link
Collaborator Author

mtrmac commented May 19, 2022

/retest

@rhatdan
Copy link
Member

rhatdan commented May 20, 2022

@mtrmac Could you remove the DRAFT, we can just merge this.
LGTM

@mtrmac
Copy link
Collaborator Author

mtrmac commented May 21, 2022

Removed WIP. Note that, because distributions wants us to use released versions of dependencies (unlike this PR, which moves from a commit reference to a commit reference) basically the only truly valuable part of this PR is the release note.

@mtrmac mtrmac marked this pull request as ready for review May 21, 2022 19:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2022
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks, @mtrmac !

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 769e777 into containers:main May 23, 2022
@mtrmac mtrmac deleted the test-gpgme-build branch May 23, 2022 13:15
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants