implement podman pod clone #14299
Merged
implement podman pod clone #14299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/release-note-label-needed
cdoern
force-pushed
the
podClone
branch
9 times, most recently
from
d0abb91 to
7d68e92
Compare
|
@containers/podman-maintainers PTAL |
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Luap99
reviewed
Jun 9, 2022
|
@edsantiago same failure here: https://github.com/containers/podman/pull/14299/checks?check_run_id=6815997255 as #14400 ... possible issue from #14543 ? or maybe a registry issue |
implement podman pod clone, a command to create an exact copy of a pod while changing certain config elements current supported flags are: --name change the pod name --destroy remove the original pod --start run the new pod on creation and all infra-container related flags from podman pod create (namespaces etc) resolves containers#12843 Signed-off-by: cdoern <[email protected]>
|
@Luap99 does this look good to go now? |
|
Code LGTM |
|
/lgtm |
cdoern
added a commit
to cdoern/podman
that referenced
this pull request
Jun 16, 2022
[NO NEW TESTS NEEDED] podman pod clone somehow snuck by the new linter code that went in while it was in flight fix that here Signed-off-by: cdoern <[email protected]>
openshift-ci bot
added a commit
that referenced
this pull request
Jun 16, 2022
linter fix from #14299
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Sep 9, 2022
This one is a nightmare, because --volume has been edited in four different files throughout the years (five if you count podman-build, which I am not including in this PR). Those edits have not always been done in sync. The list of options was reordered 2022-06-28 by Giuseppe in containers#14734, but only in podman-create and -run (not in podman-pod-*). No explanation of why, but I'll assume he knew what he was doing, and have accepted that for the reference copy. There was also a big edit in containers#8519. The "Propagation property...bind mounted" sentence first appeared in pod-clone, in containers#14299 by cdoern, with no obvious source of where it came from. I choose to include it in the reference copy. The "**copy**" option seems to work in pod-create, so I'm including it in the reference copy. Someone please yell loudly if this is not the case. The "disables SELinux separation for containers used in the build", no idea, changed that to just "for the container/pod" The "advanced users / overlay / upperdir / workdir" paragraph makes zero sense to me, but hey, I assume it applies to all the commands, so I put it in the reference copy. Finally, there's still a mishmash of backticks, asterisks, underscores, and even quotation marks. Someone is gonna have to perform major cleanup on this one day, but at least it'll be in only one place. Signed-off-by: Ed Santiago <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement podman pod clone, a command to create an exact copy of a pod while changing certain config elements
current supported (new) flags are:
--name, change the pod name
--destroy, remove the original pod
--start, run the new pod on creation
and all infra-container related flags from podman pod create (namespaces etc)
resolves #12843
Does this PR introduce a user-facing change?
Signed-off-by: cdoern [email protected]