fix compat image resolution #14294
fix compat image resolution #14294
Conversation
openshift-ci
bot
added
release-note
approved
|
LGTM |
|
@mheon, I think that's a good candidate for a v4.1 backport. |
|
Sure |
openshift-ci
bot
added
the
do-not-merge/hold
|
@vrothberg looks like you might need to tweak the tests further. |
Fix a bug in the resolution of images in the Docker compat API. When looking up an image by a short name, the name may match an image that does not live on Docker Hub. The resolved name should be used for normalization instead of the input name to make sure that `busybox` can resolve to `registry.com/busybox` if present in the local storage. Fixes: containers#14291 Signed-off-by: Valentin Rothberg <[email protected]>
Should turn green now. |
|
Ready to get in ✔️ |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@flouthoc can you merge? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick v4.1 |
|
@vrothberg: new pull request created: #14337 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
github-actions
bot
added
the
locked - please file new issue/PR
Fix a bug in the resolution of images in the Docker compat API.
When looking up an image by a short name, the name may match
an image that does not live on Docker Hub. The resolved name
should be used for normalization instead of the input name to
make sure that
busyboxcan resolve toregistry.com/busyboxif present in the local storage.
Fixes: #14291
Signed-off-by: Valentin Rothberg [email protected]
Does this PR introduce a user-facing change?