Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup strange buildtag edit #14229

Merged
merged 1 commit into from
May 16, 2022

Conversation

n1hility
Copy link
Member

@n1hility n1hility commented May 12, 2022

Not sure if it was my IDE or what, but somehow I ended up with a repeated bogus value in the build tag as part of #14206

Sorry I missed this.

[NO NEW TESTS NEEDED]

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CI is barking because [NO NEW TESTS NEEDED] isn't in the commit message.

@rhatdan
Copy link
Member

rhatdan commented May 13, 2022

You are going to need to repush.

Signed-off-by: Jason T. Greene <[email protected]>
@mheon
Copy link
Member

mheon commented May 16, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2022
@mheon
Copy link
Member

mheon commented May 16, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, n1hility

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2022
@openshift-merge-robot openshift-merge-robot merged commit eb26fa4 into containers:main May 16, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants