test: update fedora toolbox image #14175
Conversation
openshift-ci
bot
added
the
approved
test/e2e/config.go
Outdated
| @@ -14,7 +14,7 @@ var ( | |||
| BB = "quay.io/libpod/busybox:latest" | |||
| healthcheck = "quay.io/libpod/alpine_healthcheck:latest" | |||
| ImageCacheDir = "/tmp/podman/imagecachedir" | |||
| fedoraToolbox = "registry.fedoraproject.org/f32/fedora-toolbox:latest" | |||
| fedoraToolbox = "registry.fedoraproject.org/fedora-toolbox:latest" | |||
There was a problem hiding this comment.
I am afraid of using a latest tag outside of our control. Can we pin it to a version?
@edsantiago WDYT?
There was a problem hiding this comment.
You already know what I think, and you said it :-)
There was a problem hiding this comment.
the alternatives seem worse to me though:
[f29/fedora-toolbox](https://registry.fedoraproject.org/repo/f29%2Ffedora-toolbox/tags)
[docker pull registry.fedoraproject.org/f29/fedora-toolbox](https://registry.fedoraproject.org/repo/f29%2Ffedora-toolbox/tags)
[f30/fedora-toolbox](https://registry.fedoraproject.org/repo/f30%2Ffedora-toolbox/tags)
[docker pull registry.fedoraproject.org/f30/fedora-toolbox](https://registry.fedoraproject.org/repo/f30%2Ffedora-toolbox/tags)
[f31/fedora-toolbox](https://registry.fedoraproject.org/repo/f31%2Ffedora-toolbox/tags)
[docker pull registry.fedoraproject.org/f31/fedora-toolbox](https://registry.fedoraproject.org/repo/f31%2Ffedora-toolbox/tags)
[f32/fedora-toolbox](https://registry.fedoraproject.org/repo/f32%2Ffedora-toolbox/tags)
[docker pull registry.fedoraproject.org/f32/fedora-toolbox](https://registry.fedoraproject.org/repo/f32%2Ffedora-toolbox/tags)
[f33/fedora-toolbox](https://registry.fedoraproject.org/repo/f33%2Ffedora-toolbox/tags)
[docker pull registry.fedoraproject.org/f33/fedora-toolbox](https://registry.fedoraproject.org/repo/f33%2Ffedora-toolbox/tags)
[f34/fedora-toolbox](https://registry.fedoraproject.org/repo/f34%2Ffedora-toolbox/tags)
[docker pull registry.fedoraproject.org/f34/fedora-toolbox](https://registry.fedoraproject.org/repo/f34%2Ffedora-toolbox/tags)
[fedora-toolbox](https://registry.fedoraproject.org/repo/fedora-toolbox/tags)
[docker pull registry.fedoraproject.org/fedora-toolbox](https://registry.fedoraproject.org/repo/fedora-toolbox/tags)
Not sure what is the status of that image, but it doesn't even provide a F35 version. F34 will be EOL in one week.
There was a problem hiding this comment.
@HarryMichal, git indicates you added that image with commit a1e1a3a. Can you give us guidance on which image we should use?
There was a problem hiding this comment.
@HarryMichal, git indicates you added that image with commit a1e1a3a. Can you give us guidance on which image we should use?
The proposed change is correct and you can replace the latest tag with a number that matches a released Fedora version. So a safe choice now would be registry.fedoraproject.org/fedora-toolbox:35 or even registry.fedoraproject.org/fedora-toolbox:36 but probably a bit more stable-ish version is desired here.
The background behind the change can be found in containers/toolbox#615.
There was a problem hiding this comment.
thanks for the explanation.
Switched to fedora-toolbox:36
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
f32 is already EOL. Let's use the latest version. Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
update-toolbox-image
branch
from
b29aa35 to
6025892
Compare
|
ready for review |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
f32 is already EOL. Let's use the latest version.
Signed-off-by: Giuseppe Scrivano [email protected]
Does this PR introduce a user-facing change?