Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machine events: only open sockets when needed #14108

Merged
merged 1 commit into from
May 4, 2022

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented May 4, 2022

We should only open the socket when needed and not always at init time.

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2022
@Luap99
Copy link
Member Author

Luap99 commented May 4, 2022

@jwhonce @baude PTAL

@baude
Copy link
Member

baude commented May 4, 2022

LGTM

@baude baude added the 4.1 label May 4, 2022
We should only open the socket when needed and not always at init time.

[NO NEW TESTS NEEDED]

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99 Luap99 force-pushed the machine-event-sock branch from ea6cde7 to a5800c7 Compare May 4, 2022 13:08
@rhatdan
Copy link
Member

rhatdan commented May 4, 2022

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2022
@rhatdan
Copy link
Member

rhatdan commented May 4, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2022
@openshift-merge-robot openshift-merge-robot merged commit 88e50d9 into containers:main May 4, 2022
@Luap99 Luap99 deleted the machine-event-sock branch May 4, 2022 15:12
@baude
Copy link
Member

baude commented May 4, 2022

/cherry-pick v4.1

1 similar comment
@Luap99
Copy link
Member Author

Luap99 commented May 4, 2022

/cherry-pick v4.1

@openshift-cherrypick-robot
Copy link
Collaborator

@baude: new pull request created: #14114

In response to this:

/cherry-pick v4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Collaborator

@Luap99: new pull request could not be created: failed to create pull request against containers/podman#v4.1 from head openshift-cherrypick-robot:cherry-pick-14108-to-v4.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-14108-to-v4.1."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick v4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants