volume: add new option -o o=noquota #14051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
flouthoc
reviewed
Apr 28, 2022
libpod/runtime_volume_linux.go
Outdated
| return nil, errors.New("Volume options size and inodes not supported. Filesystem does not support Project Quota") | ||
| if volume.config.DisableQuota { | ||
| if volume.config.Size > 0 || volume.config.Inodes > 0 { | ||
| return nil, errors.New("Volume options size and inodes cannot be used without quota.") |
There was a problem hiding this comment.
ah i think linter is not happy
- return nil, errors.New("Volume options size and inodes cannot be used without quota.")
+ return nil, errors.New("volume options size and inodes cannot be used without quota")
flouthoc
reviewed
Apr 28, 2022
libpod/runtime_volume_linux.go
Outdated
| quota := quota.Quota{} | ||
| if volume.config.Size > 0 || volume.config.Inodes > 0 { | ||
| if !projectQuotaSupported { | ||
| return nil, errors.New("Volume options size and inodes not supported. Filesystem does not support Project Quota") |
add a new option to completely disable xfs quota usage for a volume. xfs quota set on a volume, even just for tracking disk usage, can cause weird errors if the volume is later re-used by a container with a different quota projid. More specifically, link(2) and rename(2) might fail with EXDEV if the source file has a projid that is different from the parent directory. To prevent such kind of issues, the volume should be created beforehand with `podman volume create -o o=noquota $ID` Closes: containers#14049 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
volume-create-noquota-option
branch
from
f75323f to
91ead15
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
edsantiago
added
the
kind/feature
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a new option to completely disable xfs quota usage for a volume.
xfs quota set on a volume, even just for tracking disk usage, can
cause weird errors if the volume is later re-used by a container with
a different quota projid. More specifically, link(2) and rename(2)
might fail with EXDEV if the source file has a projid that is
different from the parent directory.
To prevent such kind of issues, the volume should be created
beforehand with
podman volume create -o o=noquota $IDCloses: #14049
Signed-off-by: Giuseppe Scrivano [email protected]