Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report correct RemoteURI #14037

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Apr 27, 2022

Rather than assuming a filesystem path, the API service URI is recorded
in the libpod runtime configuration and then reported as requested.

Note: All schemes other than "unix" are hard-coded to report URI exists.

Fixes #12023

Signed-off-by: Jhon Honce [email protected]
Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2022
@rhatdan
Copy link
Member Author

rhatdan commented Apr 27, 2022

Replaces: #12895

Trying to help out @jwhonce

@rhatdan rhatdan added the 4.1 label Apr 27, 2022
@edsantiago
Copy link
Member

This is a copy-paste error of a copy-paste error. Needs to be containerLen, not ls:
https://github.com/containers/podman/blob/2dad5c07db4d8443f9b72b0719a13ab16d1163ce/test/e2e/play_kube_test.go#L3186-L3187

@rhatdan rhatdan force-pushed the remoteuri branch 2 times, most recently from 598cf5f to 91d07c7 Compare April 28, 2022 17:39
@umohnani8
Copy link
Member

Changes LGTM but tests are unhappy

@rhatdan rhatdan force-pushed the remoteuri branch 4 times, most recently from fe79242 to 5d773e3 Compare May 4, 2022 12:47
Rather than assuming a filesystem path, the API service URI is recorded
in the libpod runtime configuration and then reported as requested.

Note: All schemes other than "unix" are hard-coded to report URI exists.

Fixes containers#12023

Signed-off-by: Jhon Honce <[email protected]>
Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan
Copy link
Member Author

rhatdan commented May 4, 2022

/cherry-pick 4.1

@openshift-cherrypick-robot
Copy link
Collaborator

@rhatdan: once the present PR merges, I will cherry-pick it on top of 4.1 in a new PR and assign it to you.

In response to this:

/cherry-pick 4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@baude
Copy link
Member

baude commented May 4, 2022

LGTM

@rhatdan rhatdan added the lgtm Indicates that a PR is ready to be merged. label May 4, 2022
@openshift-merge-robot openshift-merge-robot merged commit bdaac4b into containers:main May 4, 2022
@openshift-cherrypick-robot
Copy link
Collaborator

@rhatdan: cannot checkout 4.1: error checking out 4.1: exit status 1. output: error: pathspec '4.1' did not match any file(s) known to git

In response to this:

/cherry-pick 4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@baude
Copy link
Member

baude commented May 4, 2022

/cherry-pick v4.1

@openshift-cherrypick-robot
Copy link
Collaborator

@baude: new pull request created: #14119

In response to this:

/cherry-pick v4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman system service: what should .Host.RemoteSocket.Path be?
6 participants