Rootfull -> Rootful #13995
Merged
Rootfull -> Rootful #13995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cc3790f. We can't change rootful to rootfull because `rootful` is written into the machine config. Changing this will break json unmarshalling, which will break existing machines. [NO NEW TESTS NEEDED] Signed-off-by: Ashley Cui <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
I don't think we have to remove everything. It should be enough to use the old struct field name. |
|
We should PS about this. |
|
Thank you @ashley-cui this is a particularly contentious peeve of mine. I appreciate your efforts. There is not, and never should be, any such thing as two-el "rootfull". It is an abomination. |
ashley-cui
changed the title
ashley-cui
force-pushed
the
revrootful
branch
3 times, most recently
from
66f4f7d to
892b758
Compare
Luap99
reviewed
Apr 25, 2022
vendor/github.com/containers/common/libnetwork/netavark/network.go
Outdated
Show resolved
Hide resolved
Some docs say roofull. Change to rootful. [NO NEW TESTS NEEDED] Signed-off-by: Ashley Cui <[email protected]>
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cc3790f. And changes more docs.
We can't change rootful to rootfull because
rootfulis written into the machine config. Changing this will break json unmarshalling, which will break existing machines.[NO NEW TESTS NEEDED]
Signed-off-by: Ashley Cui [email protected]