replace golint with revive linter #13973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
vrothberg
reviewed
Apr 22, 2022
| @@ -28,7 +27,7 @@ func Archive(w http.ResponseWriter, r *http.Request) { | |||
| case http.MethodHead, http.MethodGet: | |||
| handleHeadAndGet(w, r, decoder, runtime) | |||
| default: | |||
| utils.Error(w, http.StatusNotImplemented, errors.New(fmt.Sprintf("unsupported method: %v", r.Method))) | |||
| utils.Error(w, http.StatusNotImplemented, errors.Errorf("unsupported method: %v", r.Method)) | |||
There was a problem hiding this comment.
Suggested change
| utils.Error(w, http.StatusNotImplemented, errors.Errorf("unsupported method: %v", r.Method)) | |
| utils.Error(w, http.StatusNotImplemented, fmt.Errorf("unsupported method: %v", r.Method)) |
| @@ -49,7 +49,7 @@ type InMemoryManager struct { | |||
| // of locks. | |||
| func NewInMemoryManager(numLocks uint32) (Manager, error) { | |||
| if numLocks == 0 { | |||
| return nil, errors.Errorf("must provide a non-zero number of locks!") | |||
| return nil, errors.Errorf("must provide a non-zero number of locks") | |||
There was a problem hiding this comment.
Suggested change
| return nil, errors.Errorf("must provide a non-zero number of locks") | |
| return nil, fmt.Errorf("must provide a non-zero number of locks") |
| @@ -264,7 +264,7 @@ func (c *Container) handleRestartPolicy(ctx context.Context) (_ bool, retErr err | |||
| if c.ensureState(define.ContainerStateRunning, define.ContainerStatePaused) { | |||
| return false, nil | |||
| } else if c.state.State == define.ContainerStateUnknown { | |||
| return false, errors.Wrapf(define.ErrInternal, "invalid container state encountered in restart attempt!") | |||
| return false, errors.Wrapf(define.ErrInternal, "invalid container state encountered in restart attempt") | |||
There was a problem hiding this comment.
Suggested change
| return false, errors.Wrapf(define.ErrInternal, "invalid container state encountered in restart attempt") | |
| return false, fmt.Errorf("invalid container state encountered in restart attempt: %w", define.ErrInternal) |
There was a problem hiding this comment.
Yes lets do this as a global change separate from this PR.
|
@vrothberg I would prefer to make such changes in a different commit/PR. |
golint, scopelint and interfacer are deprecated. golint is replaced by revive. This linter is better because it will also check for our error style: `error strings should not be capitalized or end with punctuation or a newline` scopelint is replaced by exportloopref (already endabled) interfacer has no replacement but I do not think this linter is important. Signed-off-by: Paul Holzinger <[email protected]>
|
LGTM |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
LGTM |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golint, scopelint and interfacer are deprecated. golint is replaced by
revive. This linter is better because it will also check for our error
style:
error strings should not be capitalized or end with punctuation or a newlinescopelint is replaced by exportloopref (already endabled)
interfacer has no replacement but I do not think this linter is
important.