Fix size-check to display more context #13955
Conversation
When going through the rebase+build loop, the repository state won't match the exact branch or PR history. This results in the `Building: XYZSHA` indications being entirely useless. Fix this by at least including the title line of the commit being built. This will allow a human to make sense of any size-check failure WRT their view of history. Signed-off-by: Chris Evich <[email protected]>
|
Example log from PR #13376, |
|
Note: The effect of this PR can't be observed until the changes land in |
|
That seems odd: I distinctly remember going through Cirrus logs confirming that hashes matched 1:1 to those on my laptop - and they did, otherwise, as you say, the hashes would be useless. I think I would've been happier with an explicit /lgtm |
| @@ -92,9 +92,10 @@ if [[ ! -d $context_dir ]]; then | |||
| fi | |||
|
|
|||
| # This is the original (and primary) purpose of this check: if 'make' fails, | |||
| # there is no point in continuing | |||
| # there is no point in continuing. Show at least the commit title since | |||
| # the ID may not match anything human recognisable. | |||
There was a problem hiding this comment.
| # the ID may not match anything human recognisable. | |
| # the ID may not match anything human recognizable. |
There was a problem hiding this comment.
damn, codespell must not be turned on.
|
LGTM |
|
/lgtm |
I believe you. In case it helps, I did go poking around on the VM while the test was running and it appeared like maybe the 'merge' commits were being skipped over. I wasn't looking very carefully though, but it could easily be something like that. Maybe something in your gitconfig hid the problem? |
|
Dunno. But your approach is better regardless, thanks! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
When going through the rebase+build loop, the repository state won't
match the exact branch or PR history. This results in the
Building: XYZSHAindications being entirely useless. Fix this by at leastincluding the title line of the commit being built. This will allow a
human to make sense of any size-check failure WRT their view of history.
Signed-off-by: Chris Evich [email protected]