Allow changing of CPUs, Memory, and Disk Size #13953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
ashley-cui
force-pushed
the
mach
branch
2 times, most recently
from
d8998ac to
7732ce0
Compare
rhatdan
reviewed
Apr 21, 2022
rhatdan
reviewed
Apr 21, 2022
rhatdan
reviewed
Apr 21, 2022
rhatdan
reviewed
Apr 21, 2022
rhatdan
reviewed
Apr 21, 2022
rhatdan
reviewed
Apr 21, 2022
rhatdan
reviewed
Apr 21, 2022
rhatdan
reviewed
Apr 21, 2022
rhatdan
approved these changes
Apr 21, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ashley-cui
force-pushed
the
mach
branch
4 times, most recently
from
74ede14 to
ed58d04
Compare
Luap99
reviewed
Apr 21, 2022
ashley-cui
added
the
do-not-merge/work-in-progress
|
I didn't see any error like |
openshift-ci
bot
added
the
needs-rebase
|
@baude bug should be fixed, thanks! |
ashley-cui
added
do-not-merge/hold
|
Holding until #13964 (comment) is resolved. |
openshift-ci
bot
removed
the
needs-rebase
ashley-cui
removed
the
do-not-merge/hold
|
LGTM |
baude
reviewed
Apr 25, 2022
baude
reviewed
Apr 25, 2022
|
the machine tests just merged. can you add some e2e tests in pkg/machine/e2e? I am willing to help/pair program with you on some! |
|
Sure, let me take a look at those! |
ashley-cui
force-pushed
the
mach
branch
2 times, most recently
from
d8e691a to
156c0a0
Compare
|
Added tests! |
Allow podman machine set to change CPUs, Memory and Disk size of a QEMU machine after its been created. Disk size can only be increased. If one setting fails to be changed, the other settings will still be applied. Signed-off-by: Ashley Cui <[email protected]>
rhatdan
added
4.1
and removed
do-not-merge/needs-unit-tests
do-not-merge/needs-integration-tests
labels
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow podman machine set to change CPUs, Memory and Disk size of a QEMU machine after its been created.
Disk size can only be increased.
If one setting fails to be changed, the other settings will still be applied.
Signed-off-by: Ashley Cui [email protected]
Fixes: #13633