Respect "Rootful" when starting WSL API Forwarding #13885
Conversation
Signed-off-by: Jason T. Greene <[email protected]>
| @@ -830,7 +830,15 @@ func launchWinProxy(v *MachineVM) (bool, string, error) { | |||
| return globalName, "", err | |||
| } | |||
|
|
|||
| dest := fmt.Sprintf("ssh://root@localhost:%d/run/podman/podman.sock", v.Port) | |||
| destSock := "/run/user/1000/podman/podman.sock" | |||
There was a problem hiding this comment.
should we hardcode 1000 here or should it be rootless.GetRootlessUID()?
There was a problem hiding this comment.
In this case the UID is referring to a fixed configuration for the Fedora distro that podman machine controls, so regardless of system configuration the guest will always have a uid of 1000 (vs rootless.GetRootlessUID which return the host value). Granted a constant value in the code would have been cleaner.
|
LGTM |
1 similar comment
|
LGTM |
|
/lgtm |
openshift-ci
bot
added
the
approved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n1hility, rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Fixes #13873
[NO NEW TESTS NEEDED]
Signed-off-by: Jason T. Greene [email protected]