-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] Bump to v3.4.6 #13858
[CI:DOCS] Bump to v3.4.6 #13858
Conversation
Signed-off-by: Matthew Heon <[email protected]>
Signed-off-by: Matthew Heon <[email protected]>
Signed-off-by: Matthew Heon <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I think you can add CI:DOCS to make this faster.
/lgtm |
@Luap99 I never remember that for release PRs. Oops. |
@mheon i think [CI:DOCS] should be in the commit itself and not just PR title |
Does that work? I thought we only scanned PR titles |
Not sure, the tests still seem to be running FWIW. |
Yeah, it requires a force-push after changing the name to retrigger CI and recognize the [CI:DOCS]. I'll change something in the readme. |
Signed-off-by: Matthew Heon <[email protected]>
@mheon checking about commit ordering, should the readme version change be before the 3.4.6 version change commit? So, maybe the 2nd commit and not the 4th commit? |
Shouldn't matter, I just added it to kick CI |
/lgtm |
/hold cancel |
3.4.5 wasn't rebased fully so we missed a minor security patch. Cut another release to fix.