Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Bump to v3.4.6 #13858

Merged
merged 4 commits into from
Apr 13, 2022
Merged

Conversation

mheon
Copy link
Member

@mheon mheon commented Apr 13, 2022

3.4.5 wasn't rebased fully so we missed a minor security patch. Cut another release to fix.

mheon added 3 commits April 13, 2022 10:33
Signed-off-by: Matthew Heon <[email protected]>
Signed-off-by: Matthew Heon <[email protected]>
Signed-off-by: Matthew Heon <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2022
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think you can add CI:DOCS to make this faster.

@rhatdan rhatdan changed the title Bump to v3.4.6 [CI:DOCS] Bump to v3.4.6 Apr 13, 2022
@rhatdan
Copy link
Member

rhatdan commented Apr 13, 2022

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2022
@mheon
Copy link
Member Author

mheon commented Apr 13, 2022

@Luap99 I never remember that for release PRs. Oops.

@lsm5
Copy link
Member

lsm5 commented Apr 13, 2022

@mheon i think [CI:DOCS] should be in the commit itself and not just PR title

@mheon
Copy link
Member Author

mheon commented Apr 13, 2022

Does that work? I thought we only scanned PR titles

@lsm5
Copy link
Member

lsm5 commented Apr 13, 2022

Not sure, the tests still seem to be running FWIW.

@mheon
Copy link
Member Author

mheon commented Apr 13, 2022

Yeah, it requires a force-push after changing the name to retrigger CI and recognize the [CI:DOCS]. I'll change something in the readme.

Signed-off-by: Matthew Heon <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2022
@lsm5
Copy link
Member

lsm5 commented Apr 13, 2022

@mheon checking about commit ordering, should the readme version change be before the 3.4.6 version change commit? So, maybe the 2nd commit and not the 4th commit?

@mheon
Copy link
Member Author

mheon commented Apr 13, 2022

Shouldn't matter, I just added it to kick CI

@Luap99
Copy link
Member

Luap99 commented Apr 13, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2022
@mheon
Copy link
Member Author

mheon commented Apr 13, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2022
@openshift-merge-robot openshift-merge-robot merged commit 2bad02d into containers:v3.4 Apr 13, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants