Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Rewrite rootless --userns=auto docs #13821

Merged

Conversation

eriksjolund
Copy link
Contributor

PR after reading
#12848

  • Remove the statement that rootless --userns=auto does not work.

  • Mention that --userns=keep-id consumes all subuids and subgids.

Signed-off-by: Erik Sjölund [email protected]

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2022
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @eriksjolund Is in this draft intentionally ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eriksjolund, flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2022
@rhatdan
Copy link
Member

rhatdan commented Apr 11, 2022

@giuseppe PTAL

@eriksjolund eriksjolund marked this pull request as ready for review April 11, 2022 12:01
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2022
@eriksjolund
Copy link
Contributor Author

@flouthoc Removing draft status.

(If I find something more to add, I could create a new PR later)

* Remove the statement that rootless --userns=auto does not work.

* Mention that --userns=keep-id consumes all subuids and subgids.

Co-authored-by: Tom Sweeney <[email protected]>

Signed-off-by: Erik Sjölund <[email protected]>
@eriksjolund eriksjolund force-pushed the fix_userns_auto_docs branch from 2649b08 to 923d454 Compare April 12, 2022 05:25
@rhatdan
Copy link
Member

rhatdan commented Apr 12, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2022
@openshift-merge-robot openshift-merge-robot merged commit 0ebd288 into containers:main Apr 12, 2022
@eriksjolund eriksjolund deleted the fix_userns_auto_docs branch July 27, 2022 04:49
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants