-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
container,inspect: convert Entrypoint
to an array instead of a string
#13811
container,inspect: convert Entrypoint
to an array instead of a string
#13811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's a breaking change but Docker-compat turns it into a fix :^)
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Convert container entrypoint from string to an array inorder to make sure there is parity between `podman inspect` and `docker inspect` Signed-off-by: Aditya R <[email protected]>
e94a347
to
0cebd15
Compare
/lgtm |
@containers/podman-maintainers PTAL |
/hold cancel |
I just noticed that this breaks our own libpod api while running @baude new machine test. The inspect struct is send over the wire, should we revert this?! |
@Luap99 I'm okay if we revert this but shouldn't we fix the test then as this is needed for docker compatibility ? anyways I don't have a strict opinion on this so If this is blocker then no issues in reverting this but we might need this at some point and we will have to fix the tests then. |
docker compat vs podman comapt? At some point we should accept that there are also podman users who use this. If we take semver seriously we cannot change this until 5.0 |
@Luap99 I think we should get this in |
The question is what is more important Docker Compatibility or Podman compatibility. |
Can we do the newer change in just Docker API? |
@rhatdan Original issue requested a fix on |
Convert container entrypoint from string to an array inorder to make
sure there is parity between
podman inspect <ctr>
anddocker inspect <ctr>
Closes: #13803