containers.no_hosts is not considered by podman system service

[reda-alaoui]

Fix #13719

Signed-off-by: Réda Housni Alaoui [email protected]

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: reda-alaoui
To complete the pull request process, please assign saschagrunert after the PR has been reviewed.
You can assign the PR to them by writing /assign @saschagrunert in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

You will need to update tests.

[reda-alaoui]

I am not fluent in Go. Could you point me to them?
FYI, I wanted to add tests calling directly the rest endpoint but didn’t find any example.

[rhatdan]

Most tests are under tests/
API Tests are in tests/apiv2

[Luap99]

This should be fixed somewhere in specgen and not in the libpod container config.

The import rule is that cli flag must always overwrite the config setting, with your change this does not work because --no-hosts=false no longer overwrites the config setting, see the failing tests.

[reda-alaoui]

@Luap99 I took inspiration from rhatdan@f40a0e7 .
But ok, I will take a look at specgen.

[reda-alaoui]

@Luap99 could you point me to an architecture overview document? I don't understand what is specgen and how it interacts with libpod.

[reda-alaoui]

In the end, the real issue for my case is #13748 . So giving up on this one.