Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: enable all cgroups when running as a service #13716

Merged

Conversation

giuseppe
Copy link
Member

enable cgroup delegation when running as a systemd service so all the
available controllers are correctly detected.

Closes: #13710

Signed-off-by: Giuseppe Scrivano [email protected]

enable cgroup delegation when running as a systemd service so all the
available controllers are correctly detected.

Closes: containers#13710

Signed-off-by: Giuseppe Scrivano <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2022
@rhatdan
Copy link
Member

rhatdan commented Mar 30, 2022

LGTM
@containers/podman-maintainers PTAL @vrothberg PTAL

@rhatdan rhatdan added the 4.0 label Mar 30, 2022
@mheon
Copy link
Member

mheon commented Mar 30, 2022

LGTM

@rhatdan
Copy link
Member

rhatdan commented Mar 30, 2022

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2022
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ncdc
Copy link

ncdc commented Mar 30, 2022

LGTM

@vrothberg
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2022
@openshift-merge-robot openshift-merge-robot merged commit 688213b into containers:main Mar 30, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cgroupControllers difference between remote and on vm(podman on mac) when trying to run rootless kind
6 participants